Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Use UTF-8 encoding & LF (Unix) end-of-line #10

Open
iperdomo opened this issue Jun 10, 2022 · 1 comment
Open

Proposal: Use UTF-8 encoding & LF (Unix) end-of-line #10

iperdomo opened this issue Jun 10, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@iperdomo
Copy link
Contributor

Context

The source code is using ASCII encoding with CRLF (windows) end of lines. When looking at diff, you find those characters ^M, e.g.

2022-06-10_970x519

Change

There are changes that require modification in the developer machine.

  • Configure your Eclipse IDE to use UTF-8 file encoding with Unix end-of-line
  • Configure your Eclipse IDE to remote trailing white-spaces

Some of this IDE settings can be recorded in a Preferences file

@iperdomo iperdomo self-assigned this Jun 10, 2022
@iperdomo iperdomo added the enhancement New feature or request label Jun 10, 2022
@iperdomo
Copy link
Contributor Author

iperdomo commented Mar 2, 2023

Other projects (bigger) also propose this 🤓 - https://bugs.openjdk.org/browse/JDK-8301971

This includes basically the following steps:

  • Tell git that the text files are encoded in UTF-8
  • Look through the code base for text files containing non-ASCII characters, and convert them to UTF-8, if they are not already
  • Update tooling used in building to recognize the fact that files are now in UTF-8 and treat them accordingly (basically, updating compiler flags).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant