Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dynamic Slug in hashnode endpoint #19

Closed
uzaxirr opened this issue Oct 3, 2021 · 3 comments
Closed

Add Dynamic Slug in hashnode endpoint #19

uzaxirr opened this issue Oct 3, 2021 · 3 comments
Assignees
Labels
bug 🐛 Something isn't working enhancement 🎉 New feature or request help wanted 🆘 Extra attention is needed

Comments

@uzaxirr
Copy link
Member

uzaxirr commented Oct 3, 2021

Currently, the slug in hashnode's endpoint is hardcoded due to GraphQL

    const GET_ARTCILE = `{
        post(slug: "beginners-guide-to-hacktoberfest-2021", hostname: ""){
          title
          content
        }
      }`

This results in posting only one post, it is desired to make the slug dynamic through hashURLParser function

@uzaxirr uzaxirr added enhancement 🎉 New feature or request help wanted 🆘 Extra attention is needed bug 🐛 Something isn't working labels Oct 3, 2021
@faraazb
Copy link
Contributor

faraazb commented Oct 6, 2021

Can I make a PR for this? I am thinking of using a placeholder (${expression}).

@uzaxirr
Copy link
Member Author

uzaxirr commented Oct 6, 2021

Can I make a PR for this? I am thinking of using a placeholder (${expression}).

Yes Go Ahead, Just make sure that you make a new branch and make the chnages

@uzaxirr uzaxirr pinned this issue Oct 7, 2021
@faraazb
Copy link
Contributor

faraazb commented Oct 7, 2021

Hey! I have made a PR, #28 .

@uzaxirr uzaxirr closed this as completed Oct 8, 2021
@uzaxirr uzaxirr unpinned this issue Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working enhancement 🎉 New feature or request help wanted 🆘 Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants