Don’t catch errors in development

When an error occurs within a request, we display a generic error page to the user. This is useful for production but hides problems in development: instead of seeing a stacktrace or error, you see an Octocat. Cute but not helpful. This disables the generic error handler middleware when `NODE_ENV=development`. This also adds `NODE_ENV=development` to `.env.example` so folks get this behaviour for free.
atlassian · Aug 13, 2019 · 835a539 · 835a539
1 parent 2b1b79f
commit 835a539
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/.env.example b/.env.example
@@ -4,6 +4,7 @@ APP_URL=
 WEBHOOK_SECRET=development
 GITHUB_CLIENT_ID=
 GITHUB_CLIENT_SECRET=
+NODE_ENV=development
 TUNNEL_PORT=4002
 TUNNEL_SUBDOMAIN=<yourname>-jira
 

diff --git a/lib/frontend/app.js b/lib/frontend/app.js
@@ -117,10 +117,15 @@ module.exports = (appTokenGenerator) => {
         Sentry.setContext('Body', req.body)
       }
       Sentry.captureException(err)
+      next(err)
     })
   }
 
   const catchErrors = async (err, req, res, next) => {
+    if (process.env.NODE_ENV === 'development') {
+      return next(err)
+    }
+
     const { data: info } = (await res.locals.client.apps.get({}))
     const errorCodes = {
       'Unauthorized': 401,