Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation notice for authentication via URL query parameters #311

Closed
IvoBCD opened this issue Feb 3, 2020 · 24 comments
Closed

Deprecation notice for authentication via URL query parameters #311

IvoBCD opened this issue Feb 3, 2020 · 24 comments
Labels
to triage Decisions need to be made before implementing

Comments

@IvoBCD
Copy link

IvoBCD commented Feb 3, 2020

GitHub is sending me a deprecation notice for authentication via URL query parameters, by GitHub's Jira integration for Atlassian.

Please use the Authorization HTTP header instead as using the access_token query parameter is deprecated.

Depending on your API usage, we'll be sending you this email reminder once every 3 days for each token and User-Agent used in API calls made on your behalf.
Just one URL that was accessed with a token and User-Agent combination will be listed in the email reminder, not all.

Visit https://developer.github.com/changes/2019-11-05-deprecated-passwords-and-authorizations-api/#authenticating-using-query-parameters for more information.

@DMonCode
Copy link

DMonCode commented Feb 6, 2020

Getting these as well. Does GitHub have an official EOL for the access_token option?

I would love to switch away from DVCS but we run a Jira Server which doesn't seem to work with this plugin replacement.

@IvoBCD
Copy link
Author

IvoBCD commented Feb 12, 2020

@DMonCode We get this error with the "new" GitHub Jira integration, not with the DVCS connector.

@dnicholson-fastly
Copy link

Yes, I'm not sure how this will affect our Jira integration. We don't want to use basic auth, and there doesn't seem to be an option for that in the DVCS Connector setup if we did. How do we maintain the functionality with Jira Data Center if we're not on Enterprise GH?

@jadametz
Copy link

@tebriel (just going off commit history - apologies if you're the wrong person here)

This is the first time I've personally looked into this integration for our (Invoca) org and was relieved to see it's maintained by GitHub! Any updates here you might be able to provide?

@tebriel
Copy link
Contributor

tebriel commented Jun 23, 2020

This is an issue with Jira https://jira.atlassian.com/browse/JSWSERVER-20414 and is being worked on by their team. Sorry for the short response, on my phone. Tag me if that doesn’t answer your question!

@Skleni
Copy link

Skleni commented Aug 27, 2020

@tebriel The issue mentioned above seems to be fixed now, but we're still getting the notifications.

@tebriel
Copy link
Contributor

tebriel commented Aug 27, 2020

@Skleni I've forwarded the issue on for prioritization, unfortunately I cannot promise any timelines for investigations at the moment.

@alittle-csdisco
Copy link

We're using Jira Cloud with this integration and are still seeing this notification pop up. Is there anything we can do?

Hello there!
On October 6th, 2020 at 22:14 (UTC) your application (JIRA) used an access token (with the User-Agent Apache-HttpClient/4.5.12 (Java/1.8.0_265)) as part of a query parameter to access an endpoint through the GitHub API.
Please use the Authorization HTTP header instead as using the access_token query parameter is deprecated.

@tebriel
Copy link
Contributor

tebriel commented Oct 7, 2020

@alittle-csdisco are you sure that you are using this app: https://marketplace.atlassian.com/apps/1219592/github-for-jira?hosting=cloud&tab=overview? We do not use java nor Apache in this application, so I'm wondering if maybe that's another jira+github connector.

@Skleni
Copy link

Skleni commented Oct 8, 2020

Weird...we're also still getting the notification. This is the app we use:
image

The Marketplace listing link points to the URL you posted above.

@bxk-sonavex
Copy link

I am using the same app and get a similar notification email recently, which does mention Apache.

On September 28th, 2020 at 22:19 (UTC) your application (JIRA) used an access token (with the User-Agent Apache-HttpClient/4.5.12 (Java/1.8.0_265)) as part of a query parameter to access an endpoint through the GitHub API:

https://api.github.com/repositories/299439409/hooks

Please use the Authorization HTTP header instead as using the access_token query parameter is deprecated.

Depending on your API usage, we'll be sending you this email reminder on a monthly basis.?

Visit https://developer.github.com/changes/2020-02-10-deprecating-auth-through-query-param for more information about suggested workarounds and removal dates.

Thanks,
The GitHub Team

@tebriel
Copy link
Contributor

tebriel commented Oct 8, 2020

@bxk-sonavex Looking at the repository you listed in that email (299439409) you have two webhooks installed on that repository. The webhooks are owned by the Jira Application, but as far as I know we don't use them. I've reached out to a coworker with some history on the application, I'm wondering if maybe we used to install repo webhooks but no longer do so.

@tebriel
Copy link
Contributor

tebriel commented Oct 8, 2020

@bxk-sonavex on second inspection, the Jira app that installed the webhooks is owned by sonavex and is separate from our Jira application. Can you look under the sonavex account and see if you have an OAuth application named JIRA owned by that account?

@bxk-sonavex
Copy link

@tebriel Right, the email was sent to the sonavex account I am managing. And yes, there is an OAuth application named JARA, on the "Authorized OAuth Apps" tab
image

And there is a Jira on the tab "Installed GitHub Apps" as well.

@alittle-csdisco
Copy link

@tebriel @bxk-sonavex that's exactly the setup we have.

On the JIRA Cloud side:

  • GitHub for Jira app installed (v1.1.1-AC) com.github.integration.production
  • No DVCS Connector Accounts/connections

On the GitHub side in our GitHub org:

  • Under "Installed GitHub Apps": JIRA
  • Under "Developer Settings -> OAuth Apps": a JIRA app owned by our org

So it seems like the culprit is the JIRA OAuth App, which maybe we don't need anymore?

@bxk-sonavex
Copy link

@tebriel Then what should be done on our side?

@Skleni
Copy link

Skleni commented Oct 9, 2020

Same setup here as well.

@tebriel
Copy link
Contributor

tebriel commented Oct 9, 2020

I'll try to give a little backstory (given my limited knowledge on this) to help you arrive at the desired state:

When Atlassian first wrote a GitHub to Jira connector, it was something that users manually created and installed. You made your own OAuth App and pointed the webhooks and setup at your custom Jira URL. This app allowed Jira to configure GitHub Repo webhooks to send data from GitHub to Jira.

The GitHub owned integration is wholly separate from the process above. It is an Application that must be installed into your Jira Organization and your GitHub organization, and uses Application Webhooks (instead of Repo webhooks). These webhooks are delivered to the GitHub+Jira Service (which we manage, code is in this repo) to update your Jira instance based on the Jira devinfo API.

Unless you are using the "Developer Settings -> OAuth Apps" version (the old way to do jira integration), delete that app that your organization owns and manages from the Advanced Tab. This is not part of the Jira+GitHub sync tool that GitHub manages and we don't control it. Our App should be listed under your "Installed Apps" section only.

Let me know if that clears some things up, thanks.

@rachellerathbone
Copy link
Contributor

Hi @IvoBCD. I'm from a team at Atlassian that is currently in the process of migrating the ownership over to us from GitHub. As a part of this, we're currently going through the backlog of issues and prs to see what can still be addressed and what should be closed.

Please let me know if @tebriel's comment addressed this issue for you so I can close/follow-up.

@rachellerathbone rachellerathbone added the awaiting response Need more input from user label May 17, 2021
@IvoBCD
Copy link
Author

IvoBCD commented May 17, 2021

@rachellerathbone We no longer got the depreciation notice, but we've since given up and uninstalled the GitHub JIRA integration since it was just too unreliable

@rachellerathbone
Copy link
Contributor

Hey @IvoBCD. I'm sorry that integration was so unreliable that you had to uninstall it.

Me and my team are actively working on the app and have identified a number of pain points for our users and areas of the app that could be improved. If you change your mind and choose to reinstall the app, we'd love to hear your feedback on the product so we can truly try to create the experience our community is after.

@bxk-sonavex
Copy link

Hey @rachellerathbone, we are currently experiencing a very annoying issue. The "Development" field shows wrong status of PR for tickets - the PR was merged successfully but shown as DECLINED. This is really annoying. Don't know who is responsible for fixing the issue now, but would like to see it resolved asap. I don't want to wast time double checking PRs in every single ticket.

@rachellerathbone
Copy link
Contributor

Hey @bxk-sonavex. Please follow 372. It's currently flagged for triaging so that our team can begin to determine what work needs to be done for this and follow up accordingly.

@rachellerathbone rachellerathbone added to triage Decisions need to be made before implementing and removed awaiting response Need more input from user labels Jul 14, 2021
@rachellerathbone
Copy link
Contributor

Closing this out as the related issue linked above is also closed when the issue was resolved. Please reopen if you need further assistance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
to triage Decisions need to be made before implementing
Projects
None yet
Development

No branches or pull requests

9 participants