Fix bug where no data would result in exception. #27

lib/adapter/send-test.js

@@ -203,6 +203,34 @@ test('should insert one item', async (t) => {
   t.true(updateOne.calledWith({ _id: 'entry:ent3' }, { $set: { ...data, _id } }, { upsert: true }))
 })
 
+test('should return noaction when no item', async (t) => {
+  const updateOne = sinon.stub().returns({
+    matchedCount: 1, modifiedCount: 1, upsertedCount: 0
+  })
+  const connection = createConnection({ updateOne })
+  const data = { id: 'ent1', type: 'entry', attributes: { title: 'Entry 1' } }
+  const request = {
+    action: 'SET',
+    params: {},
+    data: undefined,
+    endpoint: {
+      collection: 'documents',
+      db: 'database'
+    }
+  }
+  const expected = {
+    status: 'noaction',
+    error: 'No items to update',
+    data: []
+  }
+  const _id = 'entry:ent1'
+
+  const response = await send(request, connection)
+
+  t.deepEqual(response, expected)
+  t.is(updateOne.callCount, 0)
+})
+
 test('should delete one item', async (t) => {
   const deleteOne = sinon.stub().returns({ deletedCount: 1 })
   const connection = createConnection({ deleteOne })

lib/adapter/send.js

@@ -21,9 +21,11 @@ const performOnObjectOrArray = async (data, fn, action) => {
   if (Array.isArray(data)) {
     const responses = await Promise.all(data.map(fn))
     return returnOkOrError(responses, actionName)
-  } else {
+  } else if (typeof data === 'object' && data !== null) {
     const response = await fn(data)
     return returnOkOrError([response], actionName)
+  } else {
+    return { status: 'noaction', error: 'No items to update', data: [] }
   }
 }