This repository has been archived by the owner on May 9, 2024. It is now read-only.
Fix python3 support, fix mixed callstacks in release mode #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They're obsoleted by move to CMake
Build script for prerequisites is still missing
This actually builds prerequisites with VS2008 (for Python 2) or VS2015 (for Python 3).
Also add the note on how to select target Python version to compile against.
anmyachev
suggested changes
Dec 20, 2018
pyext/_pysamprof.c
Outdated
| PyObject* m = Py_InitModule3("pysamprof", module_methods, module_docstring); | ||
| if (m == NULL) return; | ||
| #endif | ||
| if (m == NULL) INIT_ERROR; |
pyext/code_reporting.c
Outdated
| PYSAMPROF_LOG(PL_INFO, "Got code object %p: '%s'", code, | ||
| PyString_AsString(code->co_name)); | ||
| PYSAMPROF_LOG(PL_INFO, "Got code object %p: '%s'", code, | ||
| GET_PYSTR_AS_PCHAR(code->co_name)); |
* Added missing break and return * Replaced tabs with spaces for better alignment
anmyachev
approved these changes
Dec 20, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Python 3 support.
Tested with Python 3.5 on Ubuntu 16.04 and Python 3.6 on Windows 10.
Fix mixed callstacks in release mode - this is done by stopping compiler from doing tail call optimization in
PyEval_EvalFrameExprobe so that probe is always present in callstack.Also drop legacy Makefiles - all is built with CMake now.
And fixed a few warnings.