Nano: fix documentation typos in tensorflow inference and quantization #7126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheaperDeng
reviewed
Jan 1, 2023
| @@ -80,7 +80,7 @@ from torchmetrics.classification import MulticlassAccuracy | |||
|
|
|||
| q_model = model.quantize(precision='int8', | |||
| accelerator=None, | |||
| calib_dataset= train_dataset, | |||
| x= train_dataset, | |||
There was a problem hiding this comment.
we are having a fix on #6925 for this.
There was a problem hiding this comment.
Ok, then that's fine!
| accuracy_criterion={'relative': 0.01, 'higher_is_better': True}, | ||
| tuning_strategy='basic', | ||
| timeout=0, | ||
| max_trials=10, |
There was a problem hiding this comment.
to be honest, what should we do to https://bigdl.readthedocs.io/en/latest/doc/Nano/QuickStart/index.html? @rnwang04 @MeouSker77 . We will meet more and more not up-to-date information for these pages and we seems to suggest our users to only read key features + how to guide.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For quantization API in tensorflow inference engine, there's no keyword argument of "calib_dataset", instead using "x" simply.