fix: Don't crash NLL classifier if all targets are unlabeled #2620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiheng
reviewed
Aug 23, 2018
| @@ -153,6 +153,9 @@ class ClassNLLCriterion[@specialized(Float, Double) T: ClassTag] | |||
| total_weight = ev.plus(total_weight, w) | |||
| i += 1 | |||
| } | |||
| if(total_weight == 0){ | |||
There was a problem hiding this comment.
there's a style check failure.
StyleCheck/spark/dl/src/main/scala/com/intel/analytics/bigdl/nn/ClassNLLCriterion.scala message=
Single Space between ')' and `{`.
line=156 column=26
|
Thanks for the contribution. Only a small issue. The Jenkins job failed at style check. Please check my comments. |
|
Okay thanks. I amended that |
|
jenkins pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
If all the targets are unlabeled (or all target classes have a weight of zero), changes total_weight from 0 to 1, so it doesn't crash in backwards() when it asserts the total weight is > 0. This doesn't change the output of forward or backwards to anything unexpected.
Related links or issues (optional)
fixed #2617