Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid duplicated Appveyor builds #1473

Merged
merged 3 commits into from Feb 4, 2020
Merged

Avoid duplicated Appveyor builds #1473

merged 3 commits into from Feb 4, 2020

Conversation

yxlao
Copy link
Collaborator

@yxlao yxlao commented Jan 30, 2020 •
edited by germanros1987

  • Remove duplicated build in appveyor.yml.
  • Sometimes, pr and the feature branch are built at the same time. Followed this to create branch filter.
    image

This change is Reviewable

@update-docs
Copy link

update-docs bot commented Jan 30, 2020

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

@yxlao yxlao requested a review from griegler January 30, 2020 06:14
germanros1987
germanros1987 suggested changes Jan 30, 2020
View reviewed changes
Copy link
Contributor

@germanros1987 germanros1987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rebase?

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @griegler)

germanros1987
germanros1987 approved these changes Feb 3, 2020
View reviewed changes
Copy link
Contributor

@germanros1987 germanros1987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any updates?

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @griegler)

@yxlao yxlao merged commit 088d78d into isl-org:master Feb 4, 2020
@yxlao yxlao deleted the appvayor-dup branch February 4, 2020 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@germanros1987 germanros1987 germanros1987 approved these changes

@griegler griegler Awaiting requested review from griegler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yxlao @germanros1987