Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support USE_SYSTEM_LIBREALSENSE flag. #3057

Merged
merged 1 commit into from Feb 20, 2021
Merged

Support USE_SYSTEM_LIBREALSENSE flag. #3057

merged 1 commit into from Feb 20, 2021

Conversation

NobuoTsukamoto
Copy link
Contributor

@NobuoTsukamoto NobuoTsukamoto commented Feb 18, 2021 •
edited by germanros1987

Resolves #3056

  • Support USE_SYSTEM_LIBREALSENSE flag.
  • If USE_SYSTEM_LIBREALSENSE=ON and BUILD_LIBREALSENSE=ON, build using pre-install librealsense.
  • If GLIBCXX_USE_CXX11_ABI=ON, USE_SYSTEM_LIBREALSENSE turn OFF. This is to avoid problems with different ABIs (Python RSBagReader.open() crash on Ubuntu #2876).

This change is Reviewable

@update-docs
Copy link

update-docs bot commented Feb 18, 2021

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

@yxlao
Copy link
Collaborator

yxlao commented Feb 20, 2021

thanks @NobuoTsukamoto NobuoTsukamoto

@yxlao yxlao self-requested a review February 20, 2021 07:59
@yxlao yxlao merged commit 41fcfdc into isl-org:master Feb 20, 2021
@ssheorey ssheorey mentioned this pull request Mar 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yxlao yxlao yxlao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support USE_SYSTEM_LIBREALSENSE flag
2 participants
@NobuoTsukamoto @yxlao