Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect patterns in update_**_for_continuation #31

Open
jposwiata opened this issue Sep 22, 2023 · 1 comment
Open

Incorrect patterns in update_**_for_continuation #31

jposwiata opened this issue Sep 22, 2023 · 1 comment
Assignees

Comments

@jposwiata
Copy link

FILL, to avoid "shifted pattern" on page boundary (I assume that 16B pattern is not handled yet and 8 is OK).

uint32_t processed = 8 * (fill_record.bytes_completed() / 8);
fill_dsc.transfer_size() -= processed;
fill_dsc.destination_address() += processed;

Does it apply to COMPARE_PATTERN?

DIF_INSERT:

uint32_t blocks_processed = bytes_completed / block_size;
bytes_completed -= blocks_processed  * block_size;
source_address += blocks_processed  * block_size;
destination_address += blocks_processed  * (block_size + DSA_DIF_SIZE);

Very similar pattern should be for DIF_STRIP.

@abdelrahim-hentabli
Copy link
Contributor

Hey @jposwiata, thanks for bringing this to our attention. I don't think that we will have time to investigate/fix this issue for the next release (v1.2.0). Would it be okay if this is addressed at a later time? If you would need this fix as soon as it is addressed, you would need to use the develop branch as opposed to a release tag

@abdelrahim-hentabli abdelrahim-hentabli self-assigned this Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants