-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CoffeeLakeFspBinPkg: Hangs w/ coreboot since update to FSP 7.0.68.40 #43
Comments
@n-huber try turning off the FSP sharing coreboot stack |
Hi @n-huber, We recently ran into this while working on TianoCore open source firmware actually. It fix it, we had to increase the size of the bootloader stack. Please see Prince's patch: https://edk2.groups.io/g/devel/message/52138
|
@jackpot51 thanks, but it's disabled by default. Seems to be part of the problem, though. @nate-desimone Did you just switch to FSP 2.1 without notice??? Please update the documentation in case. I guess we can perform that switch for upstream coreboot. But what does Intel expect customers to do? Such a big switch late in a product cycle, plus all its legal concerns (remember coreboot is a GPL project, and Intel refuses to research compatibility). |
I can confirm that it's working with increased coreboot stack and decreased heap size (config FSP_USES_CB_STACK). Please keep this issue open until all related documentation is fixed! |
@n-huber, no we did not switch CFL to FSP 2.1. We did implement the single stack feature from 2.1 in later versions of CFL FSP, but none of the bigger features like dispatch mode were ported. |
@n-huber, I have updated the Coffee Lake FSP Integration Guide as of eb25f19 to explicitly document this. Note the following except from section 3.6.2:
|
Since commit f3ecfc4 (Coffee Lake FSP 7.0.68.40) we are unable to boot our CoffeeLake-S and -H systems. FSP-M simply hangs, no error reported.
Was this build tested? If so, with what hardware and bootloader combinations?
The text was updated successfully, but these errors were encountered: