Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AVX2 intrinsic optimization #71

Merged
merged 8 commits into from Feb 21, 2019
Merged

AVX2 intrinsic optimization #71

merged 8 commits into from Feb 21, 2019

Conversation

AkilRavi
Copy link
Contributor

BiPredClipping_AVX2
BiPredClippingOnTheFly_AVX2
invTransform32

@hassount hassount requested a review from ttrigui January 11, 2019 18:29
@tianjunwork tianjunwork added the enhancement New feature or request label Jan 11, 2019
ttrigui
ttrigui reviewed Jan 14, 2019
View reviewed changes
Copy link

@ttrigui ttrigui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code reviewed ( removed unused transform SSE code and added c kernel for BiPredClippingOnTheFly).
Code tested and ready to be merged

AkilRavi and others added 4 commits January 21, 2019 11:06
@AkilRavi
Add BiPredClippingOnTheFly_AVX2 intrinsic code
cc18be9
@niranjan-mcw @AkilRavi
Add BiPredClipping_AVX2 intrinsic code
d19668d 
HEVC_BiPredClipping width 4     2.23x    259.01          576.49
HEVC_BiPredClipping width 8     8.55x    247.48          2116.88
HEVC_BiPredClipping width 16     13.71x   608.02          8337.47
HEVC_BiPredClipping width 32     31.22x   2011.41         62787.17
HEVC_BiPredClipping width 64     65.04x   8295.15         539476.88
@agopikrishna13 @AkilRavi
Add AVX2 intrinsic code for invTransform32
8c8bc4f 
  EstimateInvTransform32x32_AVX2   7.83x    44473.62        348382.25
@ttrigui @AkilRavi
+ remove unused transform SSE code
855a5b2 
+ add c kernel for BiPredClippingOnTheFly
@tianjunwork
Copy link
Contributor

Hi @ttrigui, I am not familiar with ASM to do code review. Could you let me know how I can help to get this patch merged? Thanks.

@agopikrishna13 @AkilRavi
add avx2 code for transform8x8
ed7041f 
hevc_fwd_txfm8     4.22x    1220.40         5150.50
@AkilRavi
Copy link
Contributor Author

Added AVX2 intrinsic codes for

  • EncodeQuantizedCoefficients_SSE2
  • EstimateQuantizedCoefficients_Lossy_SSE2
  • Transform8x8_SSE4_1_INTRIN

@AkilRavi
Copy link
Contributor Author

Fixed Linux build error.

@tianjunwork tianjunwork merged commit fa0702c into OpenVisualCloud:master Feb 21, 2019
tianjunwork added a commit that referenced this pull request Feb 21, 2019
@tianjunwork
Revert "AVX2 intrinsic optimization (#71)"
1cd03ad 
This reverts commit fa0702c.
@tianjunwork tianjunwork mentioned this pull request Feb 21, 2019
Merged
1480c1 pushed a commit to 1480c1/SVT-HEVC that referenced this pull request Oct 4, 2019
@AkilRavi @1480c1
AVX2 intrinsic optimization (OpenVisualCloud#71)
bc7581f
1480c1 pushed a commit to 1480c1/SVT-HEVC that referenced this pull request Oct 4, 2019
@tianjunwork @1480c1
Revert "AVX2 intrinsic optimization (OpenVisualCloud#71)"
f7aa2fd 
This reverts commit fa0702c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttrigui ttrigui ttrigui left review comments

@tianjunwork tianjunwork Awaiting requested review from tianjunwork

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@AkilRavi @tianjunwork @ttrigui @niranjan-mcw @agopikrishna13