Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KNN algorithm: added runtime dispatching by K; added faster selection… #320

Merged
merged 17 commits into from Mar 6, 2020
Merged

KNN algorithm: added runtime dispatching by K; added faster selection… #320

merged 17 commits into from Mar 6, 2020

Conversation

amgrigoriev
Copy link
Contributor

… method for 1 <= K <= 32

Description

Main goal was to customize selection methods for different ranges of K in brute force K-Nearest-Neighbors (KNN) algorithm.

Changes proposed in this pull request:
-Run-time dispatching by K was added
-Faster selection was added for K <= 32

@amgrigoriev
Copy link
Contributor Author

make test

@rlnx rlnx added the dpc++ Issue/PR related to DPC++ functionality label Jan 30, 2020
@amgrigoriev amgrigoriev requested a review from rlnx January 30, 2020 09:08
@michael-smirnov
Copy link
Contributor

make test

michael-smirnov
michael-smirnov suggested changes Jan 30, 2020
View reviewed changes
Copy link
Contributor

@michael-smirnov michael-smirnov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One common comment: it is hard to understand big functions. Please decompose functions like compute() into small pieces

algorithms/kernel/k_nearest_neighbors/oneapi/bf_knn_classification_predict_kernel_ucapi_impl.i Outdated Show resolved Hide resolved
algorithms/kernel/k_nearest_neighbors/oneapi/bf_knn_classification_predict_kernel_ucapi_impl.i Outdated Show resolved Hide resolved
algorithms/kernel/k_nearest_neighbors/oneapi/bf_knn_classification_predict_kernel_ucapi_impl.i Outdated Show resolved Hide resolved
algorithms/kernel/k_nearest_neighbors/oneapi/bf_knn_classification_predict_kernel_ucapi_impl.i Outdated Show resolved Hide resolved
service/kernel/oneapi/cl_kernels/select_indexed.cl Outdated Show resolved Hide resolved
service/kernel/oneapi/cl_kernels/select_indexed.cl Outdated Show resolved Hide resolved
service/kernel/oneapi/cl_kernels/select_indexed.cl Outdated Show resolved Hide resolved
service/kernel/oneapi/cl_kernels/select_indexed.cl Outdated Show resolved Hide resolved
service/kernel/select_indexed.cpp Outdated Show resolved Hide resolved
ntfshard
ntfshard reviewed Jan 30, 2020
View reviewed changes
service/kernel/select_indexed.cpp Outdated Show resolved Hide resolved
service/kernel/select_indexed.cpp Outdated Show resolved Hide resolved
service/kernel/select_indexed.cpp Show resolved Hide resolved
service/kernel/select_indexed.cpp Show resolved Hide resolved
service/kernel/oneapi/cl_kernels/select_indexed.cl Outdated Show resolved Hide resolved
@amgrigoriev
Copy link
Contributor Author

make test

@amgrigoriev
Copy link
Contributor Author

http://intel-ci.intel.com/ea465604-4b59-f13d-97bb-8cdcd4b723a1

@amgrigoriev
Copy link
Contributor Author

PCM: http://intel-ci.intel.com/ea480597-28a1-f17a-a236-8cdcd4b723a1

michael-smirnov
michael-smirnov suggested changes Feb 5, 2020
View reviewed changes
algorithms/kernel/k_nearest_neighbors/oneapi/bf_knn_classification_predict_kernel_ucapi_impl.i Outdated Show resolved Hide resolved
algorithms/kernel/k_nearest_neighbors/oneapi/bf_knn_classification_predict_kernel_ucapi_impl.i Outdated Show resolved Hide resolved
algorithms/kernel/k_nearest_neighbors/oneapi/bf_knn_classification_predict_kernel_ucapi_impl.i Outdated Show resolved Hide resolved
algorithms/kernel/k_nearest_neighbors/oneapi/bf_knn_classification_predict_kernel_ucapi_impl.i Outdated Show resolved Hide resolved
algorithms/kernel/k_nearest_neighbors/oneapi/bf_knn_classification_predict_kernel_ucapi_impl.i Outdated Show resolved Hide resolved
algorithms/kernel/k_nearest_neighbors/oneapi/bf_knn_classification_predict_kernel_ucapi_impl.i Outdated Show resolved Hide resolved
algorithms/kernel/k_nearest_neighbors/oneapi/bf_knn_classification_predict_kernel_ucapi_impl.i Outdated Show resolved Hide resolved
algorithms/kernel/k_nearest_neighbors/oneapi/bf_knn_classification_predict_kernel_ucapi_impl.i Outdated Show resolved Hide resolved
algorithms/kernel/k_nearest_neighbors/oneapi/bf_knn_classification_predict_kernel_ucapi_impl.i Outdated Show resolved Hide resolved
algorithms/kernel/k_nearest_neighbors/oneapi/bf_knn_classification_predict_kernel_ucapi_impl.i Show resolved Hide resolved
michael-smirnov
michael-smirnov suggested changes Feb 5, 2020
View reviewed changes
service/kernel/oneapi/cl_kernels/select_indexed.cl Outdated Show resolved Hide resolved
service/kernel/oneapi/cl_kernels/select_indexed.cl Outdated Show resolved Hide resolved
service/kernel/oneapi/cl_kernels/select_indexed.cl Outdated Show resolved Hide resolved
service/kernel/oneapi/cl_kernels/select_indexed.cl Outdated Show resolved Hide resolved
service/kernel/oneapi/cl_kernels/select_indexed.cl Outdated Show resolved Hide resolved
service/kernel/oneapi/select_indexed.h Outdated Show resolved Hide resolved
service/kernel/oneapi/select_indexed.h Outdated Show resolved Hide resolved
service/kernel/oneapi/select_indexed.h Outdated Show resolved Hide resolved
@amgrigoriev
Copy link
Contributor Author

make test

3 similar comments
@amgrigoriev
Copy link
Contributor Author

make test

@amgrigoriev
Copy link
Contributor Author

make test

@amgrigoriev
Copy link
Contributor Author

make test

@amgrigoriev
Copy link
Contributor Author

make test

@amgrigoriev
Copy link
Contributor Author

make test

@amgrigoriev
Copy link
Contributor Author

make test

1 similar comment
@amgrigoriev
Copy link
Contributor Author

make test

michael-smirnov
michael-smirnov suggested changes Feb 25, 2020
View reviewed changes
algorithms/kernel/k_nearest_neighbors/oneapi/bf_knn_classification_predict_kernel_ucapi.h Outdated Show resolved Hide resolved
algorithms/kernel/k_nearest_neighbors/oneapi/bf_knn_classification_predict_kernel_ucapi_impl.i Outdated Show resolved Hide resolved
algorithms/kernel/k_nearest_neighbors/oneapi/bf_knn_classification_predict_kernel_ucapi_impl.i Outdated Show resolved Hide resolved
algorithms/kernel/k_nearest_neighbors/oneapi/bf_knn_classification_predict_kernel_ucapi_impl.i Outdated Show resolved Hide resolved
algorithms/kernel/k_nearest_neighbors/oneapi/bf_knn_classification_predict_kernel_ucapi_impl.i Outdated Show resolved Hide resolved
algorithms/kernel/k_nearest_neighbors/oneapi/bf_knn_classification_predict_kernel_ucapi_impl.i Outdated Show resolved Hide resolved
algorithms/kernel/k_nearest_neighbors/oneapi/bf_knn_classification_predict_kernel_ucapi_impl.i Outdated Show resolved Hide resolved
algorithms/kernel/k_nearest_neighbors/oneapi/bf_knn_classification_predict_kernel_ucapi_impl.i Outdated Show resolved Hide resolved
algorithms/kernel/k_nearest_neighbors/oneapi/bf_knn_classification_predict_kernel_ucapi_impl.i Outdated Show resolved Hide resolved
algorithms/kernel/k_nearest_neighbors/oneapi/bf_knn_classification_predict_kernel_ucapi_impl.i Outdated Show resolved Hide resolved
@amgrigoriev
Copy link
Contributor Author

make test

1 similar comment
@amgrigoriev
Copy link
Contributor Author

make test

@amgrigoriev
Copy link
Contributor Author

make test

@amgrigoriev amgrigoriev merged commit 2e1d942 into oneapi-src:master Mar 6, 2020
amgrigoriev added a commit to amgrigoriev/daal that referenced this pull request Mar 6, 2020
@amgrigoriev
KNN algorithm: added runtime dispatching by K; added faster selection… (
f86857b 
oneapi-src#320)

* KNN algorithm: added runtime dispatching by K; added faster selection method for 1 <= K <= 32
amgrigoriev added a commit to amgrigoriev/daal that referenced this pull request Mar 16, 2020
@amgrigoriev
KNN algorithm: added runtime dispatching by K; added faster selection… (
8530058 
oneapi-src#320)

* KNN algorithm: added runtime dispatching by K; added faster selection method for 1 <= K <= 32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntfshard ntfshard ntfshard left review comments

@michael-smirnov michael-smirnov michael-smirnov approved these changes

@prutskov prutskov prutskov approved these changes

@KulikovNikita KulikovNikita Awaiting requested review from KulikovNikita

@rlnx rlnx Awaiting requested review from rlnx

Assignees
No one assigned
Labels
dpc++ Issue/PR related to DPC++ functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@amgrigoriev @michael-smirnov @ntfshard @prutskov @rlnx