Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skel: Replace usage of pkg_resources with importlib.resources #783

Closed
pdxjohnny opened this issue Jul 16, 2020 · 2 comments
Closed

skel: Replace usage of pkg_resources with importlib.resources #783

pdxjohnny opened this issue Jul 16, 2020 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers p3 Average Priority tS Esitmated Time To Complete: Short

Comments

@pdxjohnny
Copy link
Member

pdxjohnny commented Jul 16, 2020

Just came across this: https://docs.python.org/3/library/importlib.html#importlib.resources.path

We should get rid of some usages of pkg_resources within our codebase. This would make it so we could be zip_safe!

@pdxjohnny pdxjohnny added enhancement New feature or request good first issue Good for newcomers p3 Average Priority tS Esitmated Time To Complete: Short labels Jul 16, 2020
@Nishikoh
Copy link

Hi, I'd like to tackle that.

@pdxjohnny
Copy link
Member Author

@Nishikoh Awesome! Just let me know, or anyone on Gitter if you need more info. This should be a case of finding all the pkg_resources.resource_filename and changing them

$ git grep pkg_resources | grep resource_
dffml/util/skel.py:    pkg_resources.resource_filename("dffml", "skel")
service/http/dffml_service_http/routes.py:    pkg_resources.resource_filename("dffml_service_http", "api.js")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers p3 Average Priority tS Esitmated Time To Complete: Short
Projects
None yet
Development

No branches or pull requests

2 participants