Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BroadwellDEFspBinPkg MR2 locks IA32_FEATURE_CONTROL in FSP-M #10

Open
PatrickRudolph opened this issue Jan 8, 2019 · 11 comments
Open

Comments

@PatrickRudolph
Copy link

The IA32_FEATURE_CONTROL MSR is locked on all cores after memory init, but it should be locked in FspNotify(EnumInitPhaseReadyToBoot).
That would allow coreboot to set sane values, instead of the FSP default of 0x4.

@rminnich
Copy link

rminnich commented Jan 9, 2019

that should never be locked by anything but the kernel. Anything else is a mistake. We went through this seven years ago on chromebooks, I can't believe we're back here.

@PatrickRudolph
Copy link
Author

@nate-desimone Any update on this issue ?

@shwong1
Copy link
Contributor

shwong1 commented Feb 14, 2019

The issue will be investigated, you may contact your Intel rep or file an IPS (Intel Premier Support) ticket if it’s urgent for you. Thanks!

@PatrickRudolph
Copy link
Author

It's been a month without a reply. Any update on this issue ?

1 similar comment
@PatrickRudolph
Copy link
Author

It's been a month without a reply. Any update on this issue ?

@lsiudut
Copy link

lsiudut commented May 16, 2019

At this point it's been a months. I'm +1-ning for update on that.

@PatrickRudolph
Copy link
Author

It's been a month without a reply. Any update on this issue ?

1 similar comment
@PatrickRudolph
Copy link
Author

It's been a month without a reply. Any update on this issue ?

@PatrickRudolph
Copy link
Author

Almost a year! You must be typing very slow as it's only one line of source code to change...

@swong23
Copy link
Contributor

swong23 commented Dec 4, 2019

Root cause : after memory initialization the FSP programs "IA32_FEATURE_CONTROL" MSR with Vmx features and lock the register by setting 0th bit; once the lock bit set the register become read only.

Proposed solution : do not lock the register after memory init instead lock the register during FSP ready to boot stage .

This will be resolved in the next official release however the timeline of next release is still tbc.
For NDA customers and technology partners of Intel, you may contact your Intel Rep or file an IPS# ticket for source request or method consultation for temporary workaround on your own.

@lynxis
Copy link

lynxis commented Nov 30, 2021

@swong23 any update on this (next month this will be 3 years old)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants