Skip to content
This repository has been archived by the owner on Jan 20, 2022. It is now read-only.

Commit

Permalink
Merge pull request #127 from amorenoz/iommu
Browse files Browse the repository at this point in the history
qemu: add IOMMU Device
  • Loading branch information
Julio Montes committed May 27, 2020
2 parents 10b22ac + e57e86e commit 7efaf0b
Show file tree
Hide file tree
Showing 2 changed files with 70 additions and 0 deletions.
46 changes: 46 additions & 0 deletions qemu/qemu.go
Expand Up @@ -1861,6 +1861,52 @@ func (b BalloonDevice) deviceName(config *Config) string {
return BalloonDeviceTransport[b.Transport]
}

// IommuDev represents a Intel IOMMU Device
type IommuDev struct {
Intremap bool
DeviceIotlb bool
CachingMode bool
}

// Valid returns true if the IommuDev is valid
func (dev IommuDev) Valid() bool {
return true
}

// deviceName the qemu device name
func (dev IommuDev) deviceName() string {
return "intel-iommu"
}

// QemuParams returns the qemu parameters built out of the IommuDev.
func (dev IommuDev) QemuParams(_ *Config) []string {
var qemuParams []string
var deviceParams []string

deviceParams = append(deviceParams, dev.deviceName())
if dev.Intremap {
deviceParams = append(deviceParams, "intremap=on")
} else {
deviceParams = append(deviceParams, "intremap=off")
}

if dev.DeviceIotlb {
deviceParams = append(deviceParams, "device-iotlb=on")
} else {
deviceParams = append(deviceParams, "device-iotlb=off")
}

if dev.CachingMode {
deviceParams = append(deviceParams, "caching-mode=on")
} else {
deviceParams = append(deviceParams, "caching-mode=off")
}

qemuParams = append(qemuParams, "-device")
qemuParams = append(qemuParams, strings.Join(deviceParams, ","))
return qemuParams
}

// RTCBaseType is the qemu RTC base time type.
type RTCBaseType string

Expand Down
24 changes: 24 additions & 0 deletions qemu/qemu_test.go
Expand Up @@ -1125,3 +1125,27 @@ func TestBadCPUs(t *testing.T) {
t.Errorf("Error expected")
}
}

var (
vIommuString = "-device intel-iommu,intremap=on,device-iotlb=on,caching-mode=on"
vIommuNoCacheString = "-device intel-iommu,intremap=on,device-iotlb=on,caching-mode=off"
)

func TestIommu(t *testing.T) {
iommu := IommuDev{
Intremap: true,
DeviceIotlb: true,
CachingMode: true,
}

if !iommu.Valid() {
t.Fatalf("iommu should be valid")
}

testAppend(iommu, vIommuString, t)

iommu.CachingMode = false

testAppend(iommu, vIommuNoCacheString, t)

}

0 comments on commit 7efaf0b

Please sign in to comment.