qmp: add checks for the CPU toplogy #103
Conversation
|
The PR needs to be rebased on top of #101 |
|
l g t m. @alicefr could you add some unit tests? |
|
Hi @alicefr any update on this? also looks like the CI is not happy |
|
@alicefr sounds good to me 😃 |
alicefr
force-pushed
the
cpu_topology
branch
2 times, most recently
from
3e47a12
to
7afdaf0
Compare
|
@devimc I rebased the PR and added the tests |
qemu/qmp.go
Outdated
|
|
||
| // isDieIDSupported returns if the cpu driver and the qemu version support the die id option | ||
| func (q *QMP) isDieIDSupported(driver string) bool { | ||
| if q.version.Major > 4 || (q.version.Major == 4 && q.version.Minor >= 1) && driver == "qemu64-x86_64-cpu" { |
There was a problem hiding this comment.
in my system the driver is host-x86_64-cpu 🤔
There was a problem hiding this comment.
yeah, I had that previously but then I saw the test and here
There was a problem hiding this comment.
heh - I think qemu64-x86_64-cpu was used just for testing 😄
There was a problem hiding this comment.
@sboeuf Any idea what the correct cpu driver to use here is? Perhaps we need to check for both. Basically, we only want die-id to be specified on x86 systems.
There was a problem hiding this comment.
ok changed back to host-x86_64-cpu
There was a problem hiding this comment.
@markdryan host-x86_64-cpu is correct
$ qemu-system-x86_64 -device host-x86_64-cpu,help
host-x86_64-cpu options:
min-xlevel2=<uint32>
amd-ssbd=<bool>
vendor=<string>
...
There was a problem hiding this comment.
and the qmp command query-hotpluggable-cpus returns this:
{"props": {"core-id": 0, "thread-id": 0, "node-id": 0, "socket-id": 7}, "vcpus-count": 1, "type": "host-x86_64-cpu"}
|
@markdryan can we merge this? |
qemu/qmp.go
Outdated
|
|
||
| // isDieIDSupported returns if the cpu driver and the qemu version support the die id option | ||
| func (q *QMP) isDieIDSupported(driver string) bool { | ||
| if q.version.Major > 4 || (q.version.Major == 4 && q.version.Minor >= 1) && driver == "host-x86_64-cpu" { |
There was a problem hiding this comment.
Is this test correct? Won't it always enable die-id for qemu version 5 and above regardless of the driver?
There was a problem hiding this comment.
I added the parenthesis, sorry
Support for function isSocketIDSupported, isThreadIDSupported and isDieIDSupported. The functions check if the cpu driver and the qemu version support the id parameter. Fixes: kata-containers#102 Signed-off-by: Alice Frosi <afrosi@de.ibm.com>
Add cpu driver types in TestQMPCPUDeviceAdd Signed-off-by: Alice Frosi <afrosi@de.ibm.com>
|
Hi！Does arm64 support cpu hotplug？ |
|
@Shunnnnnnnn no, |
Support for function isSocketIDSupported, isThreadIDSupported and isDieIDSupported.
The functions check if the cpu driver and the qemu version support the
id parameter.
Fixes: #102
The support table for various param looks like:
taken from #101 (comment)
Signed-off-by: Alice Frosi afrosi@de.ibm.com