This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
qmp: support command 'query-qmp-schema' #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markdryan
reviewed
Aug 1, 2019
qemu/qmp.go
Outdated
| func (q *QMP) readLoop(fromVMCh chan<- []byte) { | ||
| scanner := bufio.NewScanner(q.conn) | ||
| if q.cfg.MaxCapacity != 0 { |
There was a problem hiding this comment.
Just wondering why this change is needed? Is it because lines can be received via QMP that are greater than 64kb?
There was a problem hiding this comment.
Yes, QMP command query-qmp-schema will return 120kb almost.
|
@BetaXOi Could you provide more detailed information in the commit message about what the patch actually does and why? Also, it looks like the new test is failing for some reason. |
The upper hyervisor manager application maybe need to wait some QMP event to control boot sequence, but the event we wanted maybe not exist in some older version, so we need query all QMP ABI and check the event is supported or not. related: kata-containers/runtime#1918 Signed-off-by: Ning Bo <ning.bo9@zte.com.cn>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upper hyervisor manager application maybe need to wait some
QMP event to control boot sequence, but the event we wanted maybe
not exist in some older version, so we need query all QMP ABI and
check the event is supported or not.
related: kata-containers/runtime#1918
Signed-off-by: Ning Bo ning.bo9@zte.com.cn