Skip to content
This repository has been archived by the owner on Jan 20, 2022. It is now read-only.

improve qemu interaction #105

Merged
merged 4 commits into from
Aug 14, 2019
Merged

improve qemu interaction #105

merged 4 commits into from
Aug 14, 2019

Conversation

bergwolf
Copy link
Member

  1. add qemu logfile so that we can check why qemu fails
  2. treat memory memory preallocation as a property for different memory backends
  3. add query-status qmp API

@bergwolf
qemu: add debug logfile
30bfcaa 
When LogFile is specified, output debug log there.

Signed-off-by: Peng Tao <bergwolf@hyper.sh>
@bergwolf
Copy link
Member Author

travis failed with:

Bad response status from coveralls: 405
<html>
<head><title>405 Not Allowed</title></head>
<body bgcolor="white">
<center><h1>405 Not Allowed</h1></center>
<hr><center>nginx</center>
</body>
</html>

devimc
devimc reviewed Aug 13, 2019
View reviewed changes
Copy link

@devimc devimc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bergwolf thanks for raising this

qemu/qmp_test.go Outdated Show resolved Hide resolved
qemu/qmp_test.go Outdated Show resolved Hide resolved
qemu/qemu.go Show resolved Hide resolved
@markdryan
Copy link
Contributor

coveralls seems to be down for maintenance.

@markdryan
Copy link
Contributor

markdryan commented Aug 14, 2019 •
edited
Loading

Coveralls seems to be fixed but the linter is complaining about something

qemu/qmp.go:254:6:warning: exported type StatusInfo should have comment or be unexported (golint)

@bergwolf
Copy link
Member Author

updated. @markdryan @devimc ptal.

markdryan
markdryan reviewed Aug 14, 2019
View reviewed changes
Copy link
Contributor

@markdryan markdryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me. Just one comment on a comment.

qemu/qemu.go Show resolved Hide resolved
qemu/qemu.go Outdated Show resolved Hide resolved
@bergwolf
qemu: fix memory prealloc handling
234e0ed 
Memory preallocation is just a property of different memory backends.
We should treat it similar to memory sharing property. Also rename
FileBackedMemShared to MemShared as it is just another memory backend
property that works with different memory backends not just file backed
memory.

Signed-off-by: Peng Tao <bergwolf@hyper.sh>
@bergwolf
qmp: add query-status API
73555a4 
So that caller can find out guest status via qmp.

Signed-off-by: Peng Tao <bergwolf@hyper.sh>
@bergwolf
test/fmt: drop extra newlines
164bd8c 
They are unneeded.

Signed-off-by: Peng Tao <bergwolf@hyper.sh>
markdryan
markdryan approved these changes Aug 14, 2019
View reviewed changes
Copy link
Contributor

@markdryan markdryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devimc devimc merged commit e6644f4 into kata-containers:master Aug 14, 2019
@coveralls
Copy link

coveralls commented Aug 14, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.3%) to 79.51% when pulling bf7adf8 on bergwolf:interaction into aa341b0 on intel:master.

This was referenced Aug 26, 2019
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@markdryan markdryan markdryan approved these changes

@devimc devimc devimc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bergwolf @markdryan @coveralls @devimc