This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
qemu: Add microvm machine type support #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With these changes, plus some minor kata-runtime changes, I can specify 'machine_type = "microvm"' in /etc/kata-containers/configuration.toml and see a 170ms (13%) improvement in startup time and a 6% reduction in memory footprint compared with 'machine_type = "pc"'. |
devimc
reviewed
Apr 23, 2020
qemu/qemu.go
Outdated
| @@ -128,6 +128,10 @@ const ( | |||
| func isDimmSupported(config *Config) bool { | |||
| switch runtime.GOARCH { | |||
| case "amd64", "386": | |||
| if config != nil && config.Machine.Type == "microvm" { | |||
There was a problem hiding this comment.
Sure. I added MachineTypeMicrovm (let me know if you prefer a different naming or to add other machine types (I decided not to as they'd be unused)). I pushed a revised commit.
Following on from kata-containers#111 which added support for multiple virtio transports, add code to use virtio-mmio as the transport when booting a guest with the microvm machine type and add a microvm case when checking for NUMA support. Also add a test case for machine string parsing. Signed-off-by: Liam Merwick <liam.merwick@oracle.com>
devimc
approved these changes
Apr 24, 2020
merwick
added a commit
to merwick/runtime
that referenced
this pull request
Apr 24, 2020
With the addition of support to govmm for multiple transports (kata-containers/govmm#111) and microvm (kata-containers/govmm#121) we can now enable support for the 'microvm' machine type in kata-runtime. Signed-off-by: Liam Merwick <liam.merwick@oracle.com>
4 tasks
jodh-intel
reviewed
Apr 24, 2020
| @@ -153,6 +162,9 @@ const ( | |||
| func (transport VirtioTransport) defaultTransport(config *Config) VirtioTransport { | |||
| switch runtime.GOARCH { | |||
| case "amd64", "386": | |||
| if config != nil && config.Machine.Type == MachineTypeMicrovm { | |||
There was a problem hiding this comment.
Does this really also apply to 32-bit?
There was a problem hiding this comment.
microvm is supported by 32-bit QEMU - is that what would decide it?
$ i386-softmmu/qemu-system-i386 -machine help | grep microvm
microvm microvm (i386)
merwick
added a commit
to merwick/runtime
that referenced
this pull request
Apr 27, 2020
With the addition of support to govmm for multiple transports (kata-containers/govmm#111) and microvm (kata-containers/govmm#121) we can now enable support for the 'microvm' machine type in kata-runtime. Signed-off-by: Liam Merwick <liam.merwick@oracle.com>
merwick
added a commit
to merwick/runtime
that referenced
this pull request
Apr 27, 2020
With the addition of support to govmm for multiple transports (kata-containers/govmm#111) and microvm (kata-containers/govmm#121) we can now enable support for the 'microvm' machine type in kata-runtime. Signed-off-by: Liam Merwick <liam.merwick@oracle.com>
merwick
added a commit
to merwick/runtime
that referenced
this pull request
Apr 27, 2020
With the addition of support to govmm for multiple transports (kata-containers/govmm#111) and microvm (kata-containers/govmm#121) we can now enable support for the 'microvm' machine type in kata-runtime. Fixes: kata-containers#2360 Signed-off-by: Liam Merwick <liam.merwick@oracle.com>
merwick
added a commit
to merwick/runtime
that referenced
this pull request
Apr 27, 2020
With the addition of support to govmm for multiple transports (kata-containers/govmm#111) and microvm (kata-containers/govmm#121) we can now enable support for the 'microvm' machine type in kata-runtime. Fixes: kata-containers#2360 Signed-off-by: Liam Merwick <liam.merwick@oracle.com>
merwick
added a commit
to merwick/runtime
that referenced
this pull request
Apr 28, 2020
With the addition of support to govmm for multiple transports (kata-containers/govmm#111) and microvm (kata-containers/govmm#121) we can now enable support for the 'microvm' machine type in kata-runtime. Fixes: kata-containers#2360 Signed-off-by: Liam Merwick <liam.merwick@oracle.com>
merwick
added a commit
to merwick/runtime
that referenced
this pull request
Apr 28, 2020
With the addition of support to govmm for multiple transports (kata-containers/govmm#111) and microvm (kata-containers/govmm#121) we can now enable support for the 'microvm' machine type in kata-runtime. Fixes: kata-containers#2360 Signed-off-by: Liam Merwick <liam.merwick@oracle.com>
merwick
added a commit
to merwick/runtime
that referenced
this pull request
Apr 28, 2020
Bring support for 'microvm' machine type (kata-containers/govmm#121) shortlog: qemu: Add microvm machine type support Fixes: kata-containers#2360 Signed-off-by: Liam Merwick <liam.merwick@oracle.com>
merwick
added a commit
to merwick/runtime
that referenced
this pull request
Apr 28, 2020
With the addition of support to govmm for multiple transports (kata-containers/govmm#111) and microvm (kata-containers/govmm#121) we can now enable support for the 'microvm' machine type in kata-runtime. Fixes: kata-containers#2360 Signed-off-by: Liam Merwick <liam.merwick@oracle.com>
merwick
added a commit
to merwick/runtime
that referenced
this pull request
Apr 29, 2020
With the addition of support to govmm for multiple transports (kata-containers/govmm#111) and microvm (kata-containers/govmm#121) we can now enable support for the 'microvm' machine type in kata-runtime. Fixes: kata-containers#2360 Signed-off-by: Liam Merwick <liam.merwick@oracle.com>
bergwolf
pushed a commit
to bergwolf/kata-containers
that referenced
this pull request
Jun 29, 2020
[ port from runtime commit 6aff077 ] With the addition of support to govmm for multiple transports (kata-containers/govmm#111) and microvm (kata-containers/govmm#121) we can now enable support for the 'microvm' machine type in kata-runtime. Signed-off-by: Liam Merwick <liam.merwick@oracle.com> Signed-off-by: Peng Tao <bergwolf@hyper.sh>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from #111 which added support for multiple virtio transports,
add code to use virtio-mmio as the transport when booting a guest with
the microvm machine type and add a microvm case when checking for
NUMA support. Also add a test case for machine string parsing.
Signed-off-by: Liam Merwick liam.merwick@oracle.com