Skip to content
This repository has been archived by the owner on Jan 20, 2022. It is now read-only.

qemu: Add max_ports option to virtio-serial device #122

Merged
merged 1 commit into from
May 8, 2020

Conversation

devimc
Copy link

@devimc devimc commented Apr 24, 2020

Allow API consumers to change the maximum number of ports in the virtio-serial
devices, setting a lower number of ports can improve the boot time and
reduce the attack surface.

fixes #120

Signed-off-by: Julio Montes julio.montes@intel.com

Allow API consumers to change the maximum number of ports in the virtio-serial
devices, setting a lower number of ports can improve the boot time and
reduce the attack surface.

fixes kata-containers#120

Signed-off-by: Julio Montes <julio.montes@intel.com>
@devimc
Copy link
Author

devimc commented Apr 24, 2020

cc @jodh-intel @grahamwhaley

Copy link

@grahamwhaley grahamwhaley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l g t m
Should there be any doc updates with this?

@devimc
Copy link
Author

devimc commented Apr 24, 2020

Should there be any doc updates with this?

nop

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 81.057% when pulling 0e98b61 on devimc:topic/qemu/maxPorts into f6f627a on intel:master.

@justin-he
Copy link

Ping,
kata runtime's change (i.e. appending "max_ports=2") depends on this pr.

@devimc devimc merged commit ad66e4c into kata-containers:master May 8, 2020
@devimc devimc deleted the topic/qemu/maxPorts branch May 29, 2020 20:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add max_ports option to virtio-serial device
5 participants