This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
github: enable github actions #138
Merged
devimc
merged 2 commits into
kata-containers:master
from
devimc:2020-08-17/enableGithubActions
Aug 19, 2020
Merged
github: enable github actions #138
devimc
merged 2 commits into
kata-containers:master
from
devimc:2020-08-17/enableGithubActions
Aug 19, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devimc
force-pushed
the
2020-08-17/enableGithubActions
branch
from
August 17, 2020 16:51
091c8eb
to
8d92921
Compare
jodh-intel
reviewed
Aug 17, 2020
devimc
force-pushed
the
2020-08-17/enableGithubActions
branch
2 times, most recently
from
August 17, 2020 17:05
ff8d9c6
to
9a36650
Compare
jodh-intel
approved these changes
Aug 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My comments are essentially nits, so...
devimc
force-pushed
the
2020-08-17/enableGithubActions
branch
8 times, most recently
from
August 17, 2020 17:55
5ed9b5c
to
a422af5
Compare
Use github actions to run unit tests. Github actions service looks more stable and reliable than travis. fixes kata-containers#136 Signed-off-by: Julio Montes <julio.montes@intel.com>
devimc
force-pushed
the
2020-08-17/enableGithubActions
branch
from
August 17, 2020 17:59
a422af5
to
1af1c0d
Compare
thanks @jodh-intel - changes applied |
amshinde
reviewed
Aug 17, 2020
run: | | ||
gopath_org=$(go env GOPATH)/src/github.com/intel/ | ||
mkdir -p ${gopath_org} | ||
ln -s ${PWD} ${gopath_org} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you need this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, we need it, otherwise goveralls
will fail because it's not in the GOPATH (go test .../.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move amd64 CI jobs to github actions Signed-off-by: Julio Montes <julio.montes@intel.com>
devimc
force-pushed
the
2020-08-17/enableGithubActions
branch
from
August 18, 2020 12:48
bcc1312
to
f5bdd53
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use github actions to run unit tests.
Github actions service looks more stable and reliable than travis.
fixes #136
Signed-off-by: Julio Montes julio.montes@intel.com