qemu: add fw_cfg flag to config

[mazzy89]

Signed-off-by: Salvatore Mazzarino dev@mazzarino.cz

Append fw_cfg flag

[devimc]

thanks @mazzy89 - I left some comments

[mazzy89]

@devimc makes complete sense. I will make the changes

[devimc]

thanks @mazzy89 - I left some comments

[devimc]

thanks @mazzy89

[devimc]

@jodh-intel please take a look

[jodh-intel]

Thanks @mazzy89.

A couple of comments.

[jodh-intel]

Thanks @mazzy89.

lgtm

[mazzy89]

@jodh-intel thank you for the fast reaction in picking up this and the nice PR flow.

[jodh-intel]

np. Thanks very much for your contribution @mazzy89!

Before this lands, please could you squash the commits into a single one please?

[mazzy89]

np. Thanks very much for your contribution @mazzy89!

Np. a pleasure. thank you for this neat and useful library.

[jodh-intel]

All green - thanks again @mazzy89!

[mazzy89]

@jodh-intel I've noticed that adding the logger to fwcfg now causes the error to be printed out always when fwcfg is empty because the validation func runs always. Is something that we want?

[jodh-intel]

@mazzy89 - I think this is a problem. And in fact looking at the fw_cfg option further, this PR isn't quite general enough - QEMU supports >=0 fw_cfg options. That implies Config.FwCfg should be an array/slice. And if it was a slice, Valid() wouldn't be called every time since it would be possible to detect the difference between the following two scenarios (which the current code cannot):

• no fw_cfg entries specified
• one invalid fw_cfg specified

If you agree, do you want to raise a follow-on PR for this?

[mazzy89]

I have a PR already to fix another issue. So I'm going to modify this in here #150

[jodh-intel]

Thanks @mazzy89.