This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
qmp: send event without blocking #82
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The process will block if the event channel without buffer and there is data in channel already or the buffer of channel is full. We should avoid this. Signed-off-by: NingBo <ning.bo9@zte.com.cn>
1 similar comment
markdryan
suggested changes
Jan 2, 2019
There was a problem hiding this comment.
This change introduces a race condition. There's now no guarantee that you'd ever receive an event. The current govmm API expects that any client that has requested to receive events is reading/selecting on the channel it provides. If it does this then nothing will block.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The process will block if the event channel without buffer and there is data in channel already or the buffer of channel is full.
We should avoid this.
related: kata-containers/runtime#1047
Signed-off-by: NingBo ning.bo9@zte.com.cn