qmp: Conditionally pass threadID and socketID when CPU device add #84
Conversation
nitkon
changed the title
| @@ -1154,6 +1154,14 @@ func (q *QMP) ExecuteCPUDeviceAdd(ctx context.Context, driver, cpuID, socketID, | |||
| "thread-id": threadID, | |||
| } | |||
|
|
|||
| if socketID != "" { | |||
There was a problem hiding this comment.
Don't we need to remove the initialisation of socket-id and thread-id in the composite literal that initialises the map? Otherwise, this patch doesn't actually do anything, apart from conditionally re-initialise keys that have already been initialised.
There was a problem hiding this comment.
@markdryan: Thanks for the review. Updated the patch.
|
Maybe we should update the function documentation as well to mention that socket-id and thread-id are optional on some platforms. |
|
@devimc Could you take a look at this? |
|
Is the travis-ci because of this PR? I guess not ... |
|
@nitkon It doesn't look like it. It seems that gometalinter has been updated and has added some new checks. Let me see if I can fix this. |
|
@nitkon please rebase your pr |
For vCPU hotplug to work on ppc64le, we need not pass threadID and socketID. So conditionally pass arguments when executing CPU device add. Fixes: kata-containers#83 Signed-off-by: Nitesh Konkar niteshkonkar@in.ibm.com
|
Rebased my PR 15 min back. Is the CI running? |
|
@markdryan @devimc : All green now. |
In order to hotplug vCPU on ppc64le, we need not
pass threadID and socketID. So conditionally pass
arguments when executing CPU device add.
Fixes: #83
Signed-off-by: Nitesh Konkar niteshkonkar@in.ibm.com