This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
Fix travis #85
Merged
Fix travis #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
January 28, 2019 15:32
staticcheck was complaining as some of the error messages returned by govmm began with a capital letter. This commit fixes the issue. Signed-off-by: Mark Ryan <mark.d.ryan@intel.com>
staticcheck was complaining as there were quite a lot of
fmt.Sprintf("%s",d) in the code where d was either a string or
had string as its underlying type.
Signed-off-by: Mark Ryan <mark.d.ryan@intel.com>
staticcheck was complaining about code that looked like
if x == true {
}
rather than
if x {
}
This commit fixes the issue.
Signed-off-by: Mark Ryan <mark.d.ryan@intel.com>
static check was complaining about code that looked like
if x == "" {
return false
}
return true
when what it wants to see is return x != "". This commit fixes the issue.
Signed-off-by: Mark Ryan <mark.d.ryan@intel.com>
By removing a redundant return statement. Signed-off-by: Mark Ryan <mark.d.ryan@intel.com>
Static check was complaining about code that looked like _ = <-ch when it wants to see simply <-ch There was only one instance of this in govmm and this commit fixes that instance. Signed-off-by: Mark Ryan <mark.d.ryan@intel.com>
The .travis file was building GoVMM with some old of date versions of Go that seem to be incompatible with the latest versions of gometalinter. This commit updates the .travis file so that we build against 1.10 and 1.11. Signed-off-by: Mark Ryan <mark.d.ryan@intel.com>
rbradford
approved these changes
Jan 28, 2019
1 similar comment
|
lgtm thanks @markdryan |
devimc
approved these changes
Jan 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The travis builds were failing due to changes to gometalinter. This PR fixes the issue by modifying the parts of the code that gometalinter was complaining about and updating the versions of Go used to build govmm in the CI builds.