Fix EltwiseReduceMod #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joserochh
reviewed
Oct 29, 2021
fboemer
force-pushed
the
fboemer/GLADE-166
branch
from
6cd8e45
to
5e5f4c7
Compare
fboemer
force-pushed
the
fboemer/GLADE-166
branch
from
5e5f4c7
to
42f057d
Compare
|
@bryan113, thanks for reporting this. Are you able to check if this PR fixes the SEAL issue microsoft/SEAL#411? |
jlhcrawford
approved these changes
Nov 1, 2021
There was a problem hiding this comment.
Was there a particular reason you didn't choose to parameterise the existing tests?
Also I don't think you needed to change the test fixture name to have the "Test" suffix if you wanted to keep it consistent with the non-parameterised tests.
Otherwise, this looks good to me.
|
I tested SEAL with HEXL commit: |
|
@fboemer Any plan to release another version of HEXL? |
fboemer
added a commit
that referenced
this pull request
Nov 8, 2021
* Fix AVVX512DQ EltwiseReduceMod
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #86