Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qat: Ability to do node configurations in cluster with large number of QAT nodes more easily #1529

Closed
Tracked by #28
mregmi opened this issue Sep 8, 2023 · 3 comments · Fixed by #1579
Closed
Tracked by #28

Comments

@mregmi
Copy link
Member

mregmi commented Sep 8, 2023

Currently we can configure Node with QAT by creating a configmap with the node name and that gets passed onto the initcontainer and the node is configured.
This does not scale well for a large Clusters with many qat nodes. The users would want to assign say some nodes for compression, some of Crypto and some for mixed.

It would be nice to have a mechanism where the configuration is done with smaller option/configuration and scales with number of nodes. One of the things, we thought about was to use labels. The nodes Labeled for Compression would be configured as compression, Similarly same things could be done for Crypto and mixed. This is just an example, but we things there should be a simpler way to configure that scales with node.

@mythi
Copy link
Contributor

mythi commented Sep 11, 2023

It would be nice to have a mechanism where the configuration is done with smaller option/configuration and scales with number of nodes

sounds like a nice-to-have at this point but we could look into allowing cluster admins to create multiple CRs so that nodeSelector field can be used to choose which (labeled) nodes the daemonSet is run.

@tkatila
Copy link
Contributor

tkatila commented Oct 13, 2023

Compress setup:

kind: ConfigMap
metadata:
  name: qat-config-compress
data:
  qat.conf: ServicesEnabled=dc
---
kind: QatDevicePlugin
metadata:
  name: qat-compress
spec:
  provisioningConfig: qat-config-compress
  nodeSelector:
    my.qat.mode: "compress"

Crypto setup:

kind: ConfigMap
metadata:
  name: qat-config-crypto
data:
  qat.conf: ServicesEnabled=asym;sym
---
kind: QatDevicePlugin
metadata:
  name: qat-crypto
spec:
  provisioningConfig: qat-config-crypto
  nodeSelector:
    my.qat.mode: "crypto"

Cluster admins would label nodes with "my.qat.mode" based on their choice.

Would this work?

@mythi
Copy link
Contributor

mythi commented Oct 13, 2023

Would this work?

this was exactly my thinking but we currently allow only one xDevicePlugin resource to be created so it won't work out-of-the box

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants