-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compile ittapi-rs' C code on Windows #38
Comments
The only information I get is that it returns exit code 2, fwiw. |
Also credits to @Jake-Shadle for noticing that the OS |
I think I understand a bit more what's going on, after using However, with that relative path, we can't package the crate anymore, because it references files that are external to the source directory. With the symbolic links solution, It's not ideal though, because it makes local development and testing of ittapi-rs on Windows painful. Wonder if there would be other ways that work on all platforms, and allow testing/publishing from every platform. |
A small reorganization of the code could maybe work: the interesting C source files would be moved to the Rust directory, and the C code itself would contain symlinks to those C files. Will try that. |
@bnjbvr, with #41 merged and #44 in the queue, this issue should be on the way to being closed. I think the remaining part may be to (1) do some more testing in a Windows environment (I have done this but I would like a double-check if possible), and (2) publish a new version of the crate--perhaps v0.2.0? (cc: @jlb6740) |
Could confirm it worked with the canonical doc example in wasmtime on Windows 👍 |
Closing, seee latest 0.2.0 release of the Rust crate. |
I've noticed that the ittapi Rust wrappers don't build anything during execution of the build script on Windows: https://github.com/intel/ittapi/blob/master/ittapi-rs/build.rs#L8-L9
When trying to remove the OS-specific guard (that is, have build.rs compile on Windows with the same code that's for Linux), I get a compiler error with MSVC's 2022 compiler. Unfortunately, the error message itself seems to be lost, so I don't have any idea of what goes wrong under the hood.
I have no actual proof of this, but I actually suspect that the bindings may have to be different for Windows: could there be ABI differences, e.g. field alignment / ordering?
cc @jlb6740 @abrown
The text was updated successfully, but these errors were encountered: