Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should not create correlation buffer if the feature is not supported #104

Open
XinfengZhang opened this issue Feb 22, 2018 · 6 comments
Open

Comments

@XinfengZhang
Copy link
Contributor

test CreateBuffer/VAAPICreateBuffer.CreateBufferWithOutData/59
it will create VAMacroblockParameterBufferType buffer, but if driver dose not support macroblock parameter, it should return failed instead of VA_STATUS_SUCCESS

@XinfengZhang
Copy link
Contributor Author

also VAQMatrixBufferType in "CreateBuffer/VAAPICreateBuffer.CreateBufferWithOutData/61 - 63"

@uartie
Copy link
Contributor

uartie commented Feb 22, 2018

@XinfengZhang how do clients/apps detect if driver supports these buffer types or not? Are there specific VA APIs that relay this information?

@XinfengZhang
Copy link
Contributor Author

no vaapi to export the information, but we should not expect all buffer type can be created. so return unsupport error should also be acceptable.

@uartie
Copy link
Contributor

uartie commented Mar 2, 2018

Is there a set of buffer types that we know are "required" to be supported by all drivers if codec is supported? I don't know if it's a good idea to just accept unsupported as a valid result for just any/every buffer type. @xhaihao any comment?

@XinfengZhang
Copy link
Contributor Author

@xhaihao any comments?

@xhaihao
Copy link
Contributor

xhaihao commented Mar 15, 2018

I agree the driver may return VA_STATUS_ERROR_UNSUPPORTED_BUFFERTYPE if the type is not supported for a given profile/entrypoint pair. In addition the doc should have a clear requirement on the required buffer type for each profile/entrypoint pair. We may update the doc in the future release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants