-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
should not create correlation buffer if the feature is not supported #104
Comments
also VAQMatrixBufferType in "CreateBuffer/VAAPICreateBuffer.CreateBufferWithOutData/61 - 63" |
@XinfengZhang how do clients/apps detect if driver supports these buffer types or not? Are there specific VA APIs that relay this information? |
no vaapi to export the information, but we should not expect all buffer type can be created. so return unsupport error should also be acceptable. |
Is there a set of buffer types that we know are "required" to be supported by all drivers if codec is supported? I don't know if it's a good idea to just accept unsupported as a valid result for just any/every buffer type. @xhaihao any comment? |
@xhaihao any comments? |
I agree the driver may return VA_STATUS_ERROR_UNSUPPORTED_BUFFERTYPE if the type is not supported for a given profile/entrypoint pair. In addition the doc should have a clear requirement on the required buffer type for each profile/entrypoint pair. We may update the doc in the future release. |
test CreateBuffer/VAAPICreateBuffer.CreateBufferWithOutData/59
it will create VAMacroblockParameterBufferType buffer, but if driver dose not support macroblock parameter, it should return failed instead of VA_STATUS_SUCCESS
The text was updated successfully, but these errors were encountered: