Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gstreamer-vaapi][vpp] CSC fail. #155

Closed
feiwan1 opened this issue Apr 25, 2018 · 11 comments
Closed

[gstreamer-vaapi][vpp] CSC fail. #155

feiwan1 opened this issue Apr 25, 2018 · 11 comments
Assignees
Labels
verifying PR: fix ready and verifying with build/test

Comments

@feiwan1
Copy link
Contributor

feiwan1 commented Apr 25, 2018

System Environment
OS Ubuntu 17.04
Kernel 4.10
Hardware Skylake Intel(R) Core(TM) i5-6600K CPU @ 3.50GHz
libva tag 2.1.0
intel-media-driver f6283e2
gst-vaapi tag 1.13.90

Reproduce Steps
Use gst cmd to convert NV12 to I420/YUY2/RGBX , and then render picture, but I420 format display black, YUY2/RGBX cmdline fail.
$ gst-launch-1.0 videotestsrc ! vaapipostproc format=2 ! vaapisink
$ gst-launch-1.0 videotestsrc ! vaapipostproc format=4 ! vaapisink
$ gst-launch-1.0 videotestsrc ! vaapipostproc format=7 ! vaapisink

Only YV12 looks good:
$ gst-launch-1.0 videotestsrc ! vaapipostproc format=3 ! vaapisink

@FurongZhang
Copy link
Contributor

We are working in progress to reproduce it.

@FurongZhang
Copy link
Contributor

NV12->I420 is related to VP, we will fix it. But for NV12->YUY2 and NV12->RGBX, no VP function is called.

@FurongZhang
Copy link
Contributor

@feiwan1 Is it possible for you to take a look at NV12->YUY2 and NV12->RGBX?

@feiwan1
Copy link
Contributor Author

feiwan1 commented May 16, 2018

@FurongZhang , Is all csc should go through VP function in driver? Is there any other way to do csc?

@FurongZhang
Copy link
Contributor

CSC should go through VP function in driver.

@FurongZhang
Copy link
Contributor

@feiwan1 This issue is fixed. Please use the latest driver(ww36) to verify that. The fix, please refer to the function in DdiMedia_CreateImage. We will close this if you verify it, thanks a lot in advance!

@feiwan1
Copy link
Contributor Author

feiwan1 commented Sep 5, 2018

@wangzj0601, Could you help to verify this patch? Thanks.

@FurongZhang
Copy link
Contributor

@wangzj0601, is it possible for you to verify it? Thanks a lot in advance!

@FurongZhang FurongZhang added the verifying PR: fix ready and verifying with build/test label Oct 17, 2018
@FurongZhang
Copy link
Contributor

Pending on submitter to verify that.

@wangzj0601
Copy link

it can be pass when convert to I420, YV12 or YUY2, but still fail when convert NV12 to RGBX with driver version ba63dbe

@feiwan1
Copy link
Contributor Author

feiwan1 commented May 14, 2020

By using glimagesink instead of vaapisink, all case looks good. So close this issue.

Thanks @FurongZhang for fixing this.

@feiwan1 feiwan1 closed this as completed May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
verifying PR: fix ready and verifying with build/test
Projects
None yet
Development

No branches or pull requests

3 participants