Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mptcpd will not work with ELL > 0.33 due to removed plugin API #84

Closed
ossama-othman opened this issue Oct 7, 2020 · 3 comments · Fixed by #93
Closed

mptcpd will not work with ELL > 0.33 due to removed plugin API #84

ossama-othman opened this issue Oct 7, 2020 · 3 comments · Fixed by #93
Assignees
Labels
bug Something isn't working
Projects
Milestone

Comments

@ossama-othman
Copy link
Member

Describe the bug
The pending ELL 0.34 release removes the l_plugin API meaning mptcpd's plugin framework will need to need to find an alternative.

To Reproduce
Steps to reproduce the behavior:

  1. Build mptcpd against ELL > 0.33.

Expected behavior
Mptcpd should compile clean against ELL > 0.33, and the mptcpd plugin test should succeed.

@ossama-othman ossama-othman added the bug Something isn't working label Oct 7, 2020
@ossama-othman ossama-othman added this to the Q3-2020 milestone Oct 7, 2020
@ossama-othman ossama-othman self-assigned this Oct 7, 2020
@ossama-othman ossama-othman added this to To do in mptcpd 0.6 via automation Oct 7, 2020
@ossama-othman ossama-othman changed the title mptcpd will not work with ELL > 0.33 due to remove plugin API mptcpd will not work with ELL > 0.33 due to removed plugin API Nov 24, 2020
@dcaratti
Copy link
Contributor

dcaratti commented Dec 10, 2020

@ossama-othman , would it be possible to build/run mptcpd without any plugin? that would speed-up the specfile review. Now it's blocked beacuse koji builds for rawhide are done against libell-0.35. Thanks!

@ossama-othman
Copy link
Member Author

@dcaratti I just created a mptcpd 0.5.1 minor release that contains the back-ported plugin framework changes from the upcoming 0.6 release that allow mptcpd to be built against versions of ELL > 0.33.

Note that 0.5.1 only contains the ELL > 0.33 support, and does not contain the changes that support the upstream Linux kernel netlink path management API found in the upcoming 0.6 release.

@dcaratti
Copy link
Contributor

dcaratti commented Dec 14, 2020

@dcaratti I just created a mptcpd 0.5.1 minor release that contains the back-ported plugin framework changes from the upcoming 0.6 release that allow mptcpd to be built against versions of ELL > 0.33.

thanks @ossama-othman , I confirm that it builds successfully !

@ossama-othman ossama-othman modified the milestones: Q3-2020, Q1-2021 Jan 11, 2021
mptcpd 0.6 automation moved this from To do to Done Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
mptcpd 0.6
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants