Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update flannel daemonset #171

Merged
merged 1 commit into from
Oct 25, 2018
Merged

Update flannel daemonset #171

merged 1 commit into from
Oct 25, 2018

Conversation

dougbtv
Copy link
Member

@dougbtv dougbtv commented Oct 17, 2018

Addresses having stuck in pod queue in Kubernetes 1.12.x

Fixes #170

@dougbtv dougbtv self-assigned this Oct 17, 2018
@dougbtv
Copy link
Member Author

dougbtv commented Oct 17, 2018

Just an FYI that I also tested this under Kubernetes 1.11.x and it works as well.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 438

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 46.465%
Totals Coverage Status
Change from base Build 435: 0.0%
Covered Lines: 414
Relevant Lines: 891
💛 - Coveralls

@s1061123
Copy link
Member

@dougbtv, could you do same at images/multus-daemonset.yml?
https://github.com/intel/multus-cni/blob/master/images/multus-daemonset.yml#L114

@dougbtv dougbtv added the release-v3 PRs to make it in release branch label Oct 18, 2018
s1061123
s1061123 approved these changes Oct 25, 2018
View reviewed changes
Copy link
Member

@s1061123 s1061123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@dougbtv
Copy link
Member Author

dougbtv commented Oct 25, 2018

Thanks for the heads up on missing that section in the Multus daemonset, appreciate it Tomo!

@dougbtv dougbtv merged commit bdf901c into k8snetworkplumbingwg:master Oct 25, 2018
s1061123 added a commit that referenced this pull request Nov 5, 2018
@s1061123
Fix example files (#171 and #183)
550f680
dougbtv pushed a commit that referenced this pull request Dec 19, 2018
@s1061123 @dougbtv
Fix example files (#171 and #183)
606efe4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s1061123 s1061123 s1061123 approved these changes

@rkamudhan rkamudhan rkamudhan approved these changes

Assignees

@dougbtv dougbtv

Labels
release-v3 PRs to make it in release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dougbtv @coveralls @s1061123 @rkamudhan