Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to release-v3 stable branch #172

Merged
merged 16 commits into from
Nov 1, 2018

Conversation

dougbtv
Copy link
Member

@dougbtv dougbtv commented Oct 18, 2018

Updates to stable branch based on discussion.

Chiefly omits:

adbea5a fixing readme file version details
a4f5fd4 Add portmap capability support

Also note:

Required modifications to 21cdfe5 resulting in a conflict due to changes in types.go likely due to git's difficulty creating a diff in the types due to both changes close to one another, and sweeping changes due to formatting.

s1061123 and others added 16 commits October 18, 2018 11:04
When `--multus-conf-file=auto` is used, 00-multus.conf will be
automatically generated from the CNI configuration file of the master
plugin (the first file in lexicographical order in cni-conf-dir).
Enabling kubelete checkpoint file  parsing to get Pod device info
so that these device information can be passed into CNI plugins
that need specific device information to work on.

Change-Id: I6630f56adc0a8307f575fc09ce9090c1ffca0337
Change-Id: I650fec86659b3690e1dc4b15bf84b6574cb0baba
making resourceMap a singleton object and only initialize it once
if one or more CRDs have a resourceName annotation in them.

Added copyright header for checkpoint/checkpoint.go.
Replaced fmt.Errorf with logging.

Change-Id: I54628d69324833e70a75dcf6533e6642dedde9b5
this changes will allow mocking checkpoint instance for unit tests

Change-Id: I72fb25d15d5c9f28577a0fcbfcd385df523a5e57
Change-Id: I53551660ffd017fe170de58abdf7a96e29178000
Change-Id: Ieb650479b6b0fef1a4ecaeb2c3c1a7c15fff43d5
This change fixes k8snetworkplumbingwg#143, to make some specific TravisCI args parameter.
Signed-off-by: Shahar Klein <shaharklein@gmail.com>
@coveralls
Copy link

coveralls commented Oct 18, 2018

Pull Request Test Coverage Report for Build 447

  • 58 of 120 (48.33%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 45.085%

Changes Missing Coverage Covered Lines Changed/Added Lines %
multus/multus.go 5 7 71.43%
checkpoint/checkpoint.go 29 43 67.44%
types/conf.go 7 27 25.93%
k8sclient/k8sclient.go 17 43 39.53%
Totals Coverage Status
Change from base Build 389: 0.08%
Covered Lines: 399
Relevant Lines: 885

💛 - Coveralls

Copy link
Member

@s1061123 s1061123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, Thanks Doug!

@rkamudhan rkamudhan added release-v3 PRs to make it in release branch to-be-tested labels Oct 31, 2018
@s1061123 s1061123 merged commit ae626b4 into k8snetworkplumbingwg:release-v3 Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-v3 PRs to make it in release branch to-be-tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants