-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to release-v3 stable branch #172
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `--multus-conf-file=auto` is used, 00-multus.conf will be automatically generated from the CNI configuration file of the master plugin (the first file in lexicographical order in cni-conf-dir).
Enabling kubelete checkpoint file parsing to get Pod device info so that these device information can be passed into CNI plugins that need specific device information to work on. Change-Id: I6630f56adc0a8307f575fc09ce9090c1ffca0337
Change-Id: I650fec86659b3690e1dc4b15bf84b6574cb0baba
making resourceMap a singleton object and only initialize it once if one or more CRDs have a resourceName annotation in them. Added copyright header for checkpoint/checkpoint.go. Replaced fmt.Errorf with logging. Change-Id: I54628d69324833e70a75dcf6533e6642dedde9b5
this changes will allow mocking checkpoint instance for unit tests Change-Id: I72fb25d15d5c9f28577a0fcbfcd385df523a5e57
Change-Id: I53551660ffd017fe170de58abdf7a96e29178000
Change-Id: Ieb650479b6b0fef1a4ecaeb2c3c1a7c15fff43d5
…g cherry pick for stable]
This change fixes k8snetworkplumbingwg#143, to make some specific TravisCI args parameter.
Signed-off-by: Shahar Klein <shaharklein@gmail.com>
…ing.Debugf value changed from string
Pull Request Test Coverage Report for Build 447
💛 - Coveralls |
s1061123
approved these changes
Oct 29, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, Thanks Doug!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to stable branch based on discussion.
Chiefly omits:
adbea5a fixing readme file version details
a4f5fd4 Add portmap capability support
Also note:
Required modifications to 21cdfe5 resulting in a conflict due to changes in
types.go
likely due to git's difficulty creating a diff in the types due to both changes close to one another, and sweeping changes due to formatting.