Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options to specify logfile & loglevel in entrypoint #280

Merged
merged 1 commit into from
Mar 7, 2019

Conversation

dougbtv
Copy link
Member

@dougbtv dougbtv commented Mar 7, 2019

Adds options to specify log level & log file in entrypoint when using config file autogeneration.

Additionally, remove exit on unknown argument for future compatibility in the, ahem, future.

@dougbtv dougbtv added the release-v3 PRs to make it in release branch label Mar 7, 2019
@coveralls
Copy link

Pull Request Test Coverage Report for Build 689

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 53.47%

Totals Coverage Status
Change from base Build 684: 0.0%
Covered Lines: 601
Relevant Lines: 1124

💛 - Coveralls

@dougbtv
Copy link
Member Author

dougbtv commented Mar 7, 2019

Just an FYI regarding the Travis tests, note that the "PR" one passes. The "push" one fails, however, this is only due to Travis apparently pulling a branch that does not exist.

Copy link
Member

@s1061123 s1061123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thanks!

@dougbtv dougbtv merged commit 5e27b3c into k8snetworkplumbingwg:master Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-v3 PRs to make it in release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants