Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directory restructure (for develop-4.0 branch) #520

Closed

Conversation

nicklesimba
Copy link
Collaborator

Moved multus-cni to Standard Go Project Layout.

General Change Log

  • Directories such as checkpoint/multus/k8sclient have been moved under pkg directory to better fit the standard layout.
  • Main function has been moved out of multus.go to main.go in cmd directory to better fit the standard layout.
  • Dockerfiles have been moved to deployments directory to better fit the standard layout.
  • Imports for project files have been modified to reflect the above changes and compile.

@coveralls
Copy link

coveralls commented Jun 10, 2020

Pull Request Test Coverage Report for Build 140049588

  • 7 of 12 (58.33%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.525%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/multus/multus.go 7 12 58.33%
Totals Coverage Status
Change from base Build 131366052: 0.0%
Covered Lines: 1065
Relevant Lines: 1489

💛 - Coveralls

@dougbtv dougbtv changed the title Restructure Directory restructure (for develop-4.0 branch) Jun 10, 2020
@dougbtv dougbtv self-requested a review June 10, 2020 19:23
@@ -0,0 +1,60 @@
// Copyright (c) 2017 Intel Corporation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about to move it to 'cmd/multus/main.go' to put another binary in the repo...

Copy link
Member

@s1061123 s1061123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README.md uses the 'https://github.com/intel/multus-cni/blob/master/doc/images/Multus.png' image, which is renamed in your PR.

Could you please change the URL?

@dougbtv
Copy link
Member

dougbtv commented Jul 7, 2020

@s1061123 Hey Tomo, we had some trouble with getting github to properly merge without a conflict, when cherry picking locally, no conflicts what-so-ever, so I decided I would pick the commit and just push it up manually.

You'll find it at the head of develop-4.0 👍

@dougbtv dougbtv closed this Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants