Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/del error fix #522

Merged
merged 1 commit into from
Jul 21, 2020
Merged

Fix/del error fix #522

merged 1 commit into from
Jul 21, 2020

Conversation

s1061123
Copy link
Member

fix #519

@coveralls
Copy link

coveralls commented Jun 11, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 176661461

  • 11 of 23 (47.83%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.4%) to 70.997%
Changes Missing Coverage Covered Lines Changed/Added Lines %
multus/multus.go 11 23 47.83%
Totals Coverage Status
Change from base Build 163335278: -0.4%
Covered Lines: 1082
Relevant Lines: 1524
💛 - Coveralls

dougbtv
dougbtv approved these changes Jul 21, 2020
View reviewed changes
Copy link
Member

@dougbtv dougbtv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks Tomo

@dougbtv dougbtv merged commit 41fefbb into k8snetworkplumbingwg:master Jul 21, 2020
@s1061123 s1061123 deleted the fix/del-error-fix branch July 21, 2020 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amorenoz amorenoz amorenoz left review comments

@dougbtv dougbtv dougbtv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix:511 is not compete, how about the cmdDel part?
4 participants
@s1061123 @coveralls @dougbtv @amorenoz