Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test/error on fail #526

Conversation

nicklesimba
Copy link
Collaborator

Added unit test for error-on-fail fix.

Proposed Changes

  • Provided unit test for error-on-fail fix.
  • Modified k8sclient.go, now uses ClientInfo as an interface and KubeClient as the struct that implements ClientInfo. This is to aid in the unit test, which uses a FakeKubeClient struct to implement ClientInfo.

@coveralls
Copy link

coveralls commented Jun 15, 2020

Pull Request Test Coverage Report for Build 138528854

  • 34 of 47 (72.34%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.8%) to 72.285%

Changes Missing Coverage Covered Lines Changed/Added Lines %
logging/logging.go 8 12 66.67%
k8sclient/k8sclient.go 23 32 71.88%
Files with Coverage Reduction New Missed Lines %
logging/logging.go 1 47.56%
Totals Coverage Status
Change from base Build 131366052: 0.8%
Covered Lines: 1085
Relevant Lines: 1501

💛 - Coveralls

@nicklesimba nicklesimba changed the title Fix/error on fail Test/error on fail Jun 16, 2020
@nicklesimba nicklesimba mentioned this pull request Jun 17, 2020
Copy link
Member

@s1061123 s1061123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!!

@nicklesimba nicklesimba closed this Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants