Add support for log rotation #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1061123
requested changes
Jun 16, 2020
There was a problem hiding this comment.
First, thank you so much for your pull request!
Almost OK to me, but let me add minor comment as following:
- Currently multus keeps
vendordirectory to build multus without go modules. Could you dogo mod vendorto update vendor package? - Could you please change
loggingFpinlogging/logging_test.gofile?
shahar-klein
force-pushed
the
log-rotation
branch
from
7404bdf
to
3cd0274
Compare
Thank you for your comments - I fixed and pushed |
Pull Request Test Coverage Report for Build 137706987
💛 - Coveralls |
girishmg
reviewed
Jun 16, 2020
logging/logging.go
Outdated
| MaxAge: 5, // days | ||
| Compress: true, | ||
| } | ||
| if w == nil { | ||
| fmt.Fprintf(os.Stderr, "multus logging: cannot open %s", filename) |
There was a problem hiding this comment.
@shahar-klein why would w be nil here?
There was a problem hiding this comment.
Thanks for the comment - fixed.
shahar-klein
force-pushed
the
log-rotation
branch
from
3cd0274
to
5e87ea8
Compare
When using debug level the log files tends to fill up quickly. Add support for log rotation using lumberjack, simple and easy to use log rotation module. Signed-off-by: Shahar Klein <sklein@nvidia.com>
shahar-klein
force-pushed
the
log-rotation
branch
from
5e87ea8
to
6ea65a2
Compare
|
/lgtm as well |
|
LGTM, too! thank you for your help! Merged. |
s1061123
approved these changes
Jun 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using debug level the log files tends to fill up quickly.
Add support for log rotation using lumberjack, simple and easy to use
log rotation module.
Signed-off-by: Shahar Klein sklein@nvidia.com