Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Enable -mod build flag to be toggled via environment variable #530

Merged
merged 1 commit into from
Jul 6, 2020

Conversation

rktidwell
Copy link
Contributor

This change will enable builds to be performed with the option of
passing the -mod flag to 'go build'. This can be done by optionally
setting the MODMODE environment variable prior to building.

For example, toggling the -mod setting for the build can be
accomplished as follows:

$ MODMODE=vendor ./build

Signed-off-by: Ryan Tidwell rtidwell@suse.com

@coveralls
Copy link

coveralls commented Jun 24, 2020

Pull Request Test Coverage Report for Build 146665559

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.544%

Totals Coverage Status
Change from base Build 138076903: 0.0%
Covered Lines: 1066
Relevant Lines: 1490

💛 - Coveralls

This change will enable builds to be performed with the option of
passing the -mod flag to 'go build'. This can be done by optionally
setting the MODMODE environment variable prior to building.

For example, toggling the -mod setting for the build can be
accomplished as follows:

```
$ MODMODE=vendor ./build
```

Signed-off-by: Ryan Tidwell <rtidwell@suse.com>
Copy link
Member

@dougbtv dougbtv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution!

@dougbtv dougbtv merged commit e4a8c9f into k8snetworkplumbingwg:master Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants