Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ARM64 support #555

Merged
merged 1 commit into from
Sep 14, 2020
Merged

Add ARM64 support #555

merged 1 commit into from
Sep 14, 2020

Conversation

shaneutt
Copy link
Contributor

Adds ARM64 support for Multus re-using the existing
strategy used to add ppc64le support in previous iterations.

Fixes #554

@shaneutt shaneutt mentioned this pull request Sep 11, 2020
Closed
@shaneutt shaneutt marked this pull request as draft September 11, 2020 12:39
@coveralls
Copy link

coveralls commented Sep 11, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 250767303

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.997%
Totals Coverage Status
Change from base Build 238189460: 0.0%
Covered Lines: 1082
Relevant Lines: 1524
💛 - Coveralls

@shaneutt shaneutt marked this pull request as ready for review September 11, 2020 13:15
@s1061123
Copy link
Member

Thank you so much for your PR, @shaneutt !

Now multus-cni no longer used travis and multus-cni uses github actions for CI.

Could you please add arm64 files as others do and modify docker*.yml ?
https://github.com/intel/multus-cni/tree/master/.github/workflows

@shaneutt
Copy link
Contributor Author

Thank you so much for your PR, @shaneutt !

Now multus-cni no longer used travis and multus-cni uses github actions for CI.

Could you please add arm64 files as others do and modify docker*.yml ?
https://github.com/intel/multus-cni/tree/master/.github/workflows

Sure thing 👍

@shaneutt
Add ARM64 to images
58d6f42 
This PR takes the existing ARM64v8 build
and creates Daemonsets in the install images
to deploy it for ARM based K8s clusters.

Fixes k8snetworkplumbingwg#554

Signed-off-by: Shane Utt <shaneutt@linux.com>
@s1061123
Copy link
Member

Looks good to me, thanks @shaneutt !

@s1061123 s1061123 merged commit 8cc60f7 into k8snetworkplumbingwg:master Sep 14, 2020
@shaneutt shaneutt deleted the shaneutt/add-arm64-support branch September 14, 2020 08:00
@shaneutt shaneutt mentioned this pull request Aug 16, 2021
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ARM64 Support
3 participants
@shaneutt @coveralls @s1061123