Cleanup multus config file 00-multus.conf when deleting daemonset #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 420789010
💛 - Coveralls |
When multus daemonset is deleted the auto generated config file 00-multus.conf is left, when new pod created and uses that conf cni file, it will fail because multus roles are removed This patch cleanup multus conf file 00-multus to allow using previous primary cni config file Signed-off-by: Mamduh Alassi <mamduhala@mellanox.com>
|
I've got to think on this one, but... I think it might need to be parameterized. |
Mmduh-483
commented
Dec 14, 2020
| if [ "$MULTUS_CONF_FILE" == "auto" ]; then | ||
| trap "rm -f $CNI_CONF_DIR/00-multus.conf" EXIT | ||
| fi | ||
|
|
||
| # Enter either sleep loop, or watch loop... | ||
| if [ "$MULTUS_CLEANUP_CONFIG_ON_EXIT" == true ]; then |
There was a problem hiding this comment.
@dougbtv "--cleanup-config-on-exit" is used to set "MULTUS_CLEANUP_CONFIG_ON_EXIT" which keep tracking that the file exists, which is confusing, do u want to change this param to something else, then use it to clean config file 00-multus.conf
|
Mmduh, currently we think that it might be a better route for these customizations to go into a custom build and/or a modified yaml file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multus daemonset is deleted the auto generated config file
00-multus.conf is left, when new pod created and uses that conf
cni file, it will fail because multus roles are removed
This patch cleanup multus conf file 00-multus to allow using previous
primary cni config file
Fixes #592