-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add validateK8sApi flag #604
Conversation
Pull Request Test Coverage Report for Build 565848041
💛 - Coveralls |
2f96a2d
to
a382c32
Compare
We decided we'll move forward, but with making this behavior configurable.
|
When this flag is set it validates that multus can communicate with Kubernetes API and if failed to communicate it fails the cni. If set to false then skip failure when multus can't get pod data Signed-off-by: Mamduh Alassi <mamduhala@mellanox.com>
@@ -22,6 +22,7 @@ RESTART_CRIO=false | |||
CRIO_RESTARTED_ONCE=false | |||
RENAME_SOURCE_CONFIG_FILE=false | |||
SKIP_BINARY_COPY=false | |||
VALIDATE_K8S_API=false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why default is false?
Thank you so much for update PR, first. multi-net-spec of NPWG defines that the plugin need to communicate to Kubernetes API and if cannot make it, plguin should cancel to create pod as error (see section 7.2 for details). So if we change 'skip api' is false as default, multus-cni does not following the multi-net-spec of NPWG. I hope that multus-cni should following spec because multus-cni is the reference implementation of multi-net-spec of NPWG. So the option should be opt-in configuration as following:
|
Yeah, let's flip that logic so the default matches the spec. And I also like the name If this is a problem, we could also bring it back up at the NPWG. |
When this flag is set it validates that multus can communicate with Kubernetes API and if failed to communicate it fails the cni. If set to false then skip failure when multus can't get pod data