Bump protobuf to v1.3.2 #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 578746776
💛 - Coveralls |
dougbtv
force-pushed
the
bump-protobuf
branch
from
62cff04
to
015a5e2
Compare
|
Why the test failed??? Let me check it offline... |
fedepaol
reviewed
Feb 10, 2021
go.mod
Outdated
| github.com/containernetworking/plugins v0.8.2 | ||
| github.com/gogo/protobuf v1.3.2 // indirect |
There was a problem hiding this comment.
I think with this only we won't cover indirect deps.
If you look at go.sum, there are still older version used. To always use 1.3.2 you need to use the replace directive
There was a problem hiding this comment.
Yeah, right. As far as I checked k8s repo, master or v1.21.0-alpha.3 only fixes the protobuf isssue.
That is what I know of, for now.
- Currently multus uses kubernetes v1.13.0 library (which contains kubelet/api/podresources/v1alpha1)
- To update protobuf we need to update v1.21.0-alpha.3 or later (or wait for bugfix version...)
- v1.21.0-alpha.3 does not have kubelet/api/podresources/v1alpha1, so multus build is failed
There was a problem hiding this comment.
So we may need to stop support old sr-iov feature (kubelet)...
dougbtv
force-pushed
the
bump-protobuf
branch
2 times, most recently
from
b819596
to
fe9f9c4
Compare
dougbtv
force-pushed
the
bump-protobuf
branch
from
fe9f9c4
to
fe42962
Compare
|
Looks good to me, thanks! Please merge it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update gogo/protobuf to v1.3.2 to fix https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-3121. The related k8s fix is here: kubernetes/kubernetes#98477
Also bumps libcni to v0.8.1