Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a trap for SIGTERM in entrypoint script #608

Merged
merged 1 commit into from
Feb 9, 2021

Conversation

dougbtv
Copy link
Member

@dougbtv dougbtv commented Feb 9, 2021

In my tests this improved the time to kubectl delete pod $multus-daemonset-pod -n kube-system by 5 seconds.

@s1061123 -- I had to use wait instead of read -- if I use sleep $x & read it waits for input before continuing, there is one spot where we sleep infinity, however, in a number of other spots we sleep inside a loop.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 552395876

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.797%

Totals Coverage Status
Change from base Build 521026319: 0.0%
Covered Lines: 1137
Relevant Lines: 1606

💛 - Coveralls

@s1061123
Copy link
Member

s1061123 commented Feb 9, 2021

@dougbtv in the case of read, you just use read, without sleep. So we could use read at the last sleep infinite.

Other cases we still use sleep <n> & wait

@s1061123
Copy link
Member

s1061123 commented Feb 9, 2021

LGTM, thanks!

@s1061123 s1061123 merged commit 63734fc into k8snetworkplumbingwg:master Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants