Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the np.bool with python built-in bool #436

Merged
merged 4 commits into from Jan 10, 2023
Merged

Replace the np.bool with python built-in bool #436

merged 4 commits into from Jan 10, 2023

Conversation

ronggegu
Copy link
Collaborator

@ronggegu ronggegu commented Jan 8, 2023

Type of Change

bug fix

Description

module 'numpy' has no attribute 'bool'

Expected Behavior & Potential Risk

model test pass

How has this PR been tested?

extension test

Dependency Change?

no

@ronggegu
Copy link
Collaborator Author

@ftian1
Copy link
Contributor

ftian1 commented Jan 10, 2023

pls fix the title of this PR. it should be more meaningful.

and this fix is incorrect. you shouldn't use np.bool_. you should use python built-in bool

@ronggegu ronggegu changed the title fix numpy bool Replace the np.bool with python built-in bool Jan 10, 2023
@chensuyue
Copy link
Contributor

/Azurepipeline run Model-Test

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ronggegu
Copy link
Collaborator Author

@chensuyue chensuyue merged commit 551ea0a into master Jan 10, 2023
@chensuyue chensuyue deleted the fix/bool branch January 10, 2023 14:21
VincyZhang pushed a commit that referenced this pull request Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants