Allow IP-based Communication #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Squashed commits: [051ee2a] error handle when alternative name not available [a09b0cb] fix communication based on ip
|
Can one of the admins verify this patch? |
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
ok to test |
|
@TortoiseHam thanks for the contribution! We will review your PR. Could you please fix flake8 issues found by our CI ? |
itrushkin
suggested changes
Jul 6, 2021
itrushkin
reviewed
Jul 8, 2021
itrushkin
reviewed
Jul 12, 2021
|
Jenkins please retry a build |
|
Jenkins please retry a build |
itrushkin
approved these changes
Jul 16, 2021
|
@TortoiseHam Thanks for the contribution!:) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables IP-based connection in addition to connecting based on registered FQDNs. It also corrects a bug which was leading to the use of incorrect default plan .yaml files.