Move execution policies, algorithm, numeric, memory details to internal headers #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in preparation for libstdc++ integration The pstl policies themselves move to internal/execution_defs.h internal/execution_impl.h now refers to internal/execution_defs.h instead of ../execution The injection of pstl execution policies into namespace std:: moves to internal/glue_execution_defs.h In general, libstdc++ will re-export the internal/glue_*.h files from the pstl implementation.
This change splits the contents of <algorithm> to two internal "glue" headers for integration with libstdc++ as follows - internal/glue_algorithm_defs.h - Includes only function prototypes, and is included by <algorithm> internal/glue_algorithm_impl.h - Has all implementation previously in <algorithm> this header is only included in <execution>. This will prevent compile-time regressions for consumers of <algorithm> (in libstdc++) which do not currently use the parallel versions of the algorithms, which are always dependent on execution policy, and thus always dependent on <execution>.
andreyfe1
requested changes
Apr 9, 2018
|
|
||
| // [partial.sort.copy] | ||
|
|
||
| template<class ExecutionPolicy, class _InputIterator, class RandomAccessIterator, class Compare> |
There was a problem hiding this comment.
ForwardIterator and RandomAccessIterator are used here according to N4700 and even N4659.
I believe ForwardIterator should be used instead of _InputIterator as you write below for partial_sort_copy without Compare
There was a problem hiding this comment.
It looks like I missed these on my pass through, I'm going to be ameding this PR with <numeric> and <memory> shortly, I'll fix this as well.
There was a problem hiding this comment.
Thank you for quick fixing
|
|
||
| template<class ExecutionPolicy, class _InputIterator, class RandomAccessIterator, class Compare> | ||
| pstl::internal::enable_if_execution_policy<ExecutionPolicy, RandomAccessIterator> | ||
| partial_sort_copy(ExecutionPolicy&& exec, _InputIterator first, _InputIterator last, RandomAccessIterator d_first, RandomAccessIterator d_last, Compare comp) { |
There was a problem hiding this comment.
The same comment as in glue_algorithm_defs.h
This change splits the contents of <algorithm> to two internal "glue" headers for integration with libstdc++ as follows - internal/glue_algorithm_defs.h - Includes only function prototypes, and is included by <algorithm> internal/glue_algorithm_impl.h - Has all implementation previously in <algorithm> this header is only included in <execution>. This will prevent compile-time regressions for consumers of <algorithm> (in libstdc++) which do not currently use the parallel versions of the algorithms, which are always dependent on execution policy, and thus always dependent on <execution>.
|
Commit 6621df6 fixes _InputIterator => ForwardIterator |
rodgert
changed the title
This is in preparation for integration with libstdc++ These changes are analogous to the changes in a previous commit for <algorithm>
internal/glue_memory_impl.h was not in previous commit
Also, conditionally pulls in only those implementation headers required if <algorithm> <numeric> and <memory> are included before <execution>
|
I've added the conditional include checks we discussed over email. FWIW, at least for the test suite build times, it makes no difference in compiler timings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation for libstdc++ integration
The pstl policies themselves move to internal/execution_defs.h
internal/execution_impl.h now refers to internal/execution_defs.h instead of
../execution
The injection of pstl execution policies into namespace std:: moves to
internal/glue_execution_defs.h
In general, libstdc++ will re-export the internal/glue_*.h files from the pstl
implementation.