New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added tests for RandomForestClassifier class_weight and sample_weight & tests for KNN #280
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to check every commit for these tests. for this it is necessary that these examples run during testing daal4py.
|
||
SK_accuracy = accuracy_score(SK_predict, y_test) | ||
D4P_accuracy = accuracy_score(D4P_predict, y_test) | ||
ratio = D4P_accuracy / SK_accuracy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose we need to check not only accuracy here by predicted labels, but additionally AUC/logloss by predicted probabilities. And probably, other metrics like F1, precision, ...
@Mergifyio rebase |
@Mergifyio rebase |
@OnlyDeniko is not allowed to run commands |
@Mergifyio rebase |
Command
|
This reverts commit 64b96c3.
… each assert, function check_data_formats_diff now checking 3 estimators: kNN, RFClassifier, RFRegressor
Command 'restart' is not supported by Azure Pipelines. Supported commands
See additional documentation. |
/azp run IntelPython.daal4py (Linux_DPCPP) |
Commenter does not have sufficient privileges for PR 280 in repo IntelPython/daal4py |
Added tests which are testing accuracy ratio RandomForestClassifier between Scikit-learn and daal4py on the next parameters: sample_weight, class_weight.