Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added tests for RandomForestClassifier class_weight and sample_weight & tests for KNN #280

Merged
merged 32 commits into from Oct 29, 2020

Conversation

OnlyDeniko
Copy link
Contributor

Added tests which are testing accuracy ratio RandomForestClassifier between Scikit-learn and daal4py on the next parameters: sample_weight, class_weight.

@OnlyDeniko OnlyDeniko changed the title added tests for RandomForestClassifier class_weight and sample_weight added tests for RandomForestClassifier class_weight and sample_weight & tests for KNN Sep 18, 2020
Copy link
Contributor

@PetrovKP PetrovKP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to check every commit for these tests. for this it is necessary that these examples run during testing daal4py.

daal4py/sklearn/neighbors/tests/test_kneighbors.py Outdated Show resolved Hide resolved
daal4py/sklearn/neighbors/tests/test_kneighbors.py Outdated Show resolved Hide resolved
daal4py/sklearn/ensemble/tests/test_decision_forest.py Outdated Show resolved Hide resolved
daal4py/sklearn/ensemble/tests/test_decision_forest.py Outdated Show resolved Hide resolved
daal4py/sklearn/ensemble/tests/test_decision_forest.py Outdated Show resolved Hide resolved

SK_accuracy = accuracy_score(SK_predict, y_test)
D4P_accuracy = accuracy_score(D4P_predict, y_test)
ratio = D4P_accuracy / SK_accuracy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose we need to check not only accuracy here by predicted labels, but additionally AUC/logloss by predicted probabilities. And probably, other metrics like F1, precision, ...

@PetrovKP
Copy link
Contributor

@Mergifyio rebase

@OnlyDeniko
Copy link
Contributor Author

@Mergifyio rebase

@mergify
Copy link

mergify bot commented Oct 22, 2020

@OnlyDeniko is not allowed to run commands

@PetrovKP
Copy link
Contributor

@Mergifyio rebase

@intel intel deleted a comment from mergify bot Oct 22, 2020
@mergify
Copy link

mergify bot commented Oct 22, 2020

Command rebase: failure

Branch rebase failed
First, rewinding head to replay your work on top of it...
Applying: added tests for RandomForestClassifier class_weight and sample_weight
Applying: License added
Applying: corrected tests for DF & KNN using pytest
Applying: end of lines added
Applying: Revert "end of lines added"
Applying: fixed gaps identified in the review
Applying: add check regression on iris & changed exceptons on asserts
Applying: added tests in CI
Applying: pytest for testing
Applying: add daal4py in source_files
Applying: fix function name & added check daal version
Applying: fix check daal version
Applying: fix check daal version
Applying: check average metrics in RF tests & format code using PEP8
Applying: fix name variables, added accracy check for kNN, added explanation of each assert, function check_data_formats_diff now checking 3 estimators: kNN, RFClassifier, RFRegressor
Applying: check version
Applying: added tests for RandomForestClassifier class_weight and sample_weight
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging daal4py/sklearn/ensemble/tests/test_decision_forest.py
CONFLICT (add/add): Merge conflict in daal4py/sklearn/ensemble/tests/test_decision_forest.py
error: Failed to merge in the changes.
Patch failed at 0017 added tests for RandomForestClassifier class_weight and sample_weight
Use 'git am --show-current-patch' to see the failed patch

Resolve all conflicts manually, mark them as resolved with
"git add/rm <conflicted_files>", then run "git rebase --continue".
You can instead skip this commit: run "git rebase --skip".
To abort and get back to the state before "git rebase", run "git rebase --abort".

err-code: AF167

@azure-pipelines
Copy link

Command 'restart' is not supported by Azure Pipelines.

Supported commands
  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
    • Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"

See additional documentation.

@OnlyDeniko
Copy link
Contributor Author

/azp run IntelPython.daal4py (Linux_DPCPP)

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 280 in repo IntelPython/daal4py

@PetrovKP PetrovKP merged commit bf032f7 into intel:master Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants